Support for DotNet 10.0

[BrianMar]

We're using node-api-dotnet on a project that is currently on DotNet 9.0. We need to update to 10.0 to pick up some required changes. It looks like this project doesn't build a DotNet 10.0 version of the library currently.

[BrianMar]

I'm seeing the "IsDotNet10SdkAvailable" flag being set in a number of projects. However, the "global.json" file locks us to version 9.0.100, so the DotNet 10.0.102 SDK isn't being picked up.

Updating the "global.json" to use "10.0.102" builds the net10.0 folders and the tests pass. So it looks like we just need to update the global.json and then publish a new version. Looking at the contributor instructions to see if DotNet update procedures are described.

[ladeak]

Maybe the previous PR gives some idea: bb2575c

Brian Marshall (@BrianMar) did you manage to get it working with .NET 10?

[ladeak]

It seems to partially work for .net 10, but it has trouble loading native libraries: when using HttpClient with HTTP/3, the msquic library fails to load.

[dotnetjunky]

ladeak Brian Marshall (@BrianMar) I created a draft PR to support .net 10 here #476 but the build failed because it couldn't restore the nuget package 'Microsoft.NET.ILLink.Tasks' version 10. Do we need to push this package to the ADO nuget feed?

[ladeak]

Yes, it seems to that is the only allowed nuget feed:

node-api-dotnet/NuGet.config

Line 4 in 8bc32e6

<!-- We must use ADO feed to be compliant. -->

EDIT: seems to be internal to MS feed, so maybe Vladimir Morozov (@vmoroz) can help with that?

[dotnetjunky]

The feed is publicly accessible, but the .nupkg file itself is protected. Vladimir Morozov (@vmoroz) Do we need to do something to make the version 10 of this assembly publicly available?

Meanwhile, I changed my draft PR to download the package from the public NuGet feed to work around this build error. (just temporarily to see if the build passes. I'll revert this change before merging)

[dotnetjunky]

ladeak Some unit tests failed. Are you familiar with those errors?

[ladeak]

No, I am not familiar with these errors. I see that these are build failures in HostedClrTests.cs L61

Assert.Fail(): Build failed. Check the log for details: D:\a\node-api-dotnet\node-api-dotnet\out\obj\Release\TestCases\napi-dotnet\net9.0\hosted-build.log
   at Microsoft.JavaScript.NodeApi.Test.HostedClrTests.Test(String id) in D:\a\node-api-dotnet\node-api-dotnet\test\HostedClrTests.cs:line 61
   at InvokeStub_HostedClrTests.Test(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

I wonder if I can see the complete logs, do you see the actual build errors? Maybe something like: Build process exited with code: from https://github.com/microsoft/node-api-dotnet/blob/main/test/TestBuilder.cs#L170 file?

[dotnetjunky]

I don't see the complete log/build error either.

[dotnetjunky]

Let me try something.

[dotnetjunky]

ladeak OK, the build passed, but I need to undo my changes to the NuGet feeds.

[ladeak]

May I ask what the issue was or how you figured it out?

[dotnetjunky]

There were 2 issues with the tests:

1. Similar to the main build, the test projects are also configured to download some packages from the ADO feed, which failed with the 401 error.
2. Due to some misconfigurations, the test projects were built with the wrong .net target framework. They were built with .net 10, instead of the framework that they are meant to be tested in.

As for how I figured it out, I didn't. I asked Github Copilot to fix it ;)

[ladeak]

Is this issue still unresolved? Luan Nguyen (@dotnetjunky) , need any help?

[dotnetjunky]

ladeak Thank you. The issue has been resolved. Recent package versions have added support for .NET 10.0