.NET Samples - Simplify sample invocaiton and miscellaneous clean-up by crickman · Pull Request #4064 · microsoft/agent-framework

crickman · 2026-02-19T03:37:29Z

Motivation and Context

As I started down the path of re-organizing the .NET samples, I noticed the usage of the <TargetFrameworks> property was unnecessarily complicating invocation.

Description

Replaced <TargetFrameworks>net10.0</TargetFrameworks> with <TargetFramework>net10.0</TargetFramework>. This eliminates the need to specify --framework net10.0 when running the sample. In short, dotnet run --framework net10.0 becomes dotnet run. High likelihood that someone's first experience running a sample is an error that says:
```
Unable to run your project
Your project targets multiple frameworks. Specify which framework to run using '--framework'.
```
Not a great experience. (Samples were only targeting net10.0 anyway.)
Removed common definition of UserSecretsId from dotnet/samples/Directory.Build.props and pushed this property to the sample .csproj.
Removed dead code under dotnet/Shared/Samples (dead code bad, mkay)
Moved SampleEnvironment from dotnet/Shared/Demos to dotnet/Shared/Samples and clarified README (We don't have a "Demos" folder...we do have a "Samples" folder.)
Marginally streamlined implementation and messaging of SampleEnvironment

Contribution Checklist

The code builds clean without any errors or warnings
The PR follows the Contribution Guidelines
All unit tests pass, and I have added new tests where possible
Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

Copilot

Pull request overview

This PR simplifies .NET sample invocation by changing from multi-targeting to single-targeting and performs miscellaneous clean-up. The primary motivation is to eliminate the need to specify --framework net10.0 when running samples, improving the first-time user experience.

Changes:

Changed all sample .csproj files from <TargetFrameworks> (plural) to <TargetFramework> (singular) for net10.0, eliminating the need to specify --framework when running samples
Removed common UserSecretsId from Directory.Build.props and added it explicitly to Declarative Workflow samples that need it
Deleted unused sample utility code (XunitLogger.cs, TextOutputHelperExtensions.cs, TestConfiguration.cs, OrchestrationSample.cs, BaseSample.cs)
Moved SampleEnvironment.cs from Shared/Demos to Shared/Samples and improved its implementation with better affirmative value handling and console color management
Updated README documentation to reflect the new structure
Simplified asset file patterns and removed unused package references

Reviewed changes

Copilot reviewed 168 out of 168 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
dotnet/samples/Directory.Build.props	Updated default target framework and changed shared code path from Demos to Samples
dotnet/src/Shared/Samples/SampleEnvironment.cs	Improved implementation with HashSet for affirmative values and better console color handling
dotnet/src/Shared/Samples/README.md	New documentation for SampleEnvironment (contains spelling errors noted below)
dotnet/src/Shared/Demos/README.md	Removed old Demos folder documentation
Multiple .csproj files (120+ files)	Changed TargetFrameworks to TargetFramework for single-targeting
Declarative workflow .csproj files	Added explicit UserSecretsId where needed
dotnet/src/Shared/Samples/*.cs	Deleted unused sample utility classes
FoundryAgents_Step15_ComputerUse.csproj	Simplified asset file copy pattern from individual files to wildcard
A2AAgent_PollingForTaskCompletion.csproj	Removed unused System.Net.ServerSentEvents package
A2AServer.csproj	Removed conditional ItemGroup that's no longer needed with single-targeting
HostedWorkflow/Program.cs	Updated placeholder comment to proper description

Copilot · 2026-02-19T04:56:41Z

dotnet/src/Shared/Samples/README.md

+# SampleEnvironemnt.cs

-Efficient sample project utilities.
+`SampleEnvironemnt.cs` defines a helper that overrides `System.Environment` class for a project.
+This override version has an enhanced `GetEnvironmentVariable` method that prompts the user
+to enter a value if the environment variable is not set.

-To use this in your project, add the following to your `.csproj` file:
+Sample code is still fully copyable to another project. This override just allow for a simplified experience
+for users who are new and just getting started.
+
+This file is already included in all samples via `/dotnet/samples/Directory.Build.props`.
+
+To explicitly use `SampleEnvironemnt.cs` outside of this repo, add the following to your `.csproj` file:


The filename contains a typo: "SampleEnvironemnt" should be "SampleEnvironment" (missing 'n' in "Environment"). This typo appears in the title and is repeated throughout the document on lines 1, 3, and 12.

@copilot open a new pull request to apply changes based on this feedback

Copilot · 2026-02-19T04:56:41Z

dotnet/src/Shared/Samples/README.md

+</ItemGroup>
+
+<ItemGroup>
+  <Compile Include="$(MSBuildThisFileDirectory)\..\src\Shared\Demos\*.cs" LinkBase="" Visible="false" />


The path in line 20 still references the old "Demos" folder but should reference "Samples" instead, consistent with the PR's goal of moving SampleEnvironment from Demos to Samples. The correct path should be: $(MSBuildThisFileDirectory)\..\src\Shared\Samples\*.cs

@copilot open a new pull request to apply changes based on this feedback

Copilot · 2026-02-19T04:56:41Z

dotnet/samples/Directory.Build.props

-    <TargetFrameworks>net10.0;net472</TargetFrameworks>
-    <UserSecretsId>5ee045b0-aea3-4f08-8d31-32d1a6f8fed0</UserSecretsId>
+    <TargetFramework>net10.0</TargetFramework>
+    <TargetFrameworks>net10.0</TargetFrameworks>


Both TargetFramework (line 12) and TargetFrameworks (line 13) are set to the same value "net10.0". This appears redundant. Consider removing line 13 <TargetFrameworks>net10.0</TargetFrameworks> since individual projects now explicitly set <TargetFramework>net10.0</TargetFramework> and this default shouldn't need the plural version.

Suggested change

<TargetFrameworks>net10.0</TargetFrameworks>

Copilot · 2026-02-19T04:56:42Z

dotnet/src/Shared/Samples/README.md

@@ -1,11 +1,22 @@
-# Throw
+# SampleEnvironemnt.cs


The title contains a typo: "invocaiton" should be "invocation".

@copilot open a new pull request to apply changes based on this feedback

dotnet/samples/Directory.Build.props

Copilot · 2026-02-19T05:45:17Z

@crickman I've opened a new pull request, #4070, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-02-19T05:45:38Z

@crickman I've opened a new pull request, #4071, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-02-19T05:45:56Z

@crickman I've opened a new pull request, #4072, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-02-19T05:46:11Z

@crickman I've opened a new pull request, #4073, to work on those changes. Once the pull request is ready, I'll request review from you.

crickman · 2026-02-19T05:46:57Z

I'm actually going to split this along separation of concerns.

Ready?

9c74705

markwallace-microsoft added documentation Improvements or additions to documentation .NET labels Feb 19, 2026

crickman had a problem deploying to integration February 19, 2026 03:37 — with GitHub Actions Error

Merge branch 'main' into crickman/dotnet-samples-portable

359bbd2

crickman had a problem deploying to integration February 19, 2026 03:39 — with GitHub Actions Error

Update new test

4d19045

crickman temporarily deployed to integration February 19, 2026 03:42 — with GitHub Actions Inactive

crickman added the samples Issue relates to the samples label Feb 19, 2026

crickman added this to Agent Framework Feb 19, 2026

crickman moved this to In Review in Agent Framework Feb 19, 2026

crickman self-assigned this Feb 19, 2026

crickman requested review from eavanvalkenburg and markwallace-microsoft February 19, 2026 04:09

crickman changed the title ~~.NET Samples - Increase sample portability and miscellaneous clean-up~~ .NET Samples - Simplify sample invocaiton and miscellaneous clean-up Feb 19, 2026

crickman marked this pull request as ready for review February 19, 2026 04:49

Copilot AI review requested due to automatic review settings February 19, 2026 04:49

Copilot started reviewing on behalf of crickman February 19, 2026 04:50 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

crickman removed request for eavanvalkenburg and markwallace-microsoft February 19, 2026 05:44

Copilot AI mentioned this pull request Feb 19, 2026

Fix README path reference from Demos to Samples #4070

Draft

4 tasks

Copilot AI mentioned this pull request Feb 19, 2026

Fix typo: SampleEnvironemnt → SampleEnvironment in Samples README #4071

Draft

4 tasks

Copilot AI mentioned this pull request Feb 19, 2026

Fix typo: SampleEnvironemnt → SampleEnvironment in README #4072

Draft

4 tasks

Copilot AI mentioned this pull request Feb 19, 2026

Fix typo in SampleEnvironment README #4073

Draft

4 tasks

crickman closed this Feb 19, 2026

github-project-automation bot moved this from In Review to Done in Agent Framework Feb 19, 2026

crickman moved this from Done to Planned in Agent Framework Feb 19, 2026

Comments

Conversation

crickman commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation and Context

Description

Contribution Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

crickman Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

crickman Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

crickman Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

crickman Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI commented Feb 19, 2026

Uh oh!

Copilot AI commented Feb 19, 2026

Uh oh!

Copilot AI commented Feb 19, 2026

Uh oh!

Copilot AI commented Feb 19, 2026

Uh oh!

crickman commented Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

crickman commented Feb 19, 2026 •

edited

Loading