Commit 87d775d
committed
feat(loader): warn on enum vocabularies ambiguous under @normalize: strip (cross-port)
@normalize: strip -- the DEFAULT -- upper-cases and keeps only [A-Z0-9]. That
erasure is what lets "SOCIAL-ATTACK" match the member SOCIAL_ATTACK, which is
desired. It also means a DELIMITED value collapses into one token, so where a
vocabulary contains a member equal to the concatenation of others, a stray
delimited value coerces SUCCESSFULLY to the wrong member:
values = {READ, WRITE, READWRITE}; input "read|write" -> READWRITE
The field is reported EXTRACTED, not MALFORMED -- a plausible wrong value that
anything branching on field state will trust. Proven against the real coercion
path before writing the guard; the control case "friendly|hostile" against
{FRIENDLY, HOSTILE} correctly returns MALFORMED, which isolates the hazard to
concatenation-collision vocabularies.
It cannot be fixed at coercion time: "read-write" legitimately means READWRITE,
so the two readings are indistinguishable from the value alone. But the collision
IS detectable from metadata, so all four loaders now warn the author at
declaration time -- WARN_ENUM_NORMALIZE_AMBIGUOUS -- when a field.enum's own
@values contains a member that word-breaks into two or more other members and the
effective mode is strip. `collapse` is immune (folds only [\s_-]+, so a "|"
survives and the value fails cleanly) and is the documented fix.
Design notes:
- WARNING, never an error: such a vocabulary is legal and completely unambiguous
for exact matching, and the author may have no delimited input at all.
- Word-break (DP), not a pairwise scan, so A + B + C == ABC is caught too.
Deterministic, since every port must produce the identical warning.
- Own-@values only: warns once at the declaring node, not on every field that
extends it. Self excluded BY INDEX, not by value -- two distinct members can
strip to the same string, which is a separate (duplicate) concern.
- Mode-gated: collapse/none are structurally immune and are skipped.
Cross-port: TS reference + Java + Python + C# (Kotlin inherits the JVM loader),
gated by the shared warning-enum-normalize-ambiguous conformance fixture. A scan
of all 54 @values sets in the corpus found zero pre-existing collisions, so no
existing fixture changes and no generated output changes.
Also records in the extract KNOWN_GAPS that splitting a delimited scalar into
array elements (a @delimiter attr) is intentionally NOT offered, with the prior
art and the ADR-0037 step-0 reasoning, so it does not get re-litigated. The
supported shape is repeated elements / a JSON array + field.enum isArray: true.
Suites: TS metadata 2278, Python 1637, Java metadata 1279, C# conformance 836 +
render 290 + codegen 339 + cli 46 -- all green.1 parent 831472e commit 87d775d
16 files changed
Lines changed: 868 additions & 0 deletions
File tree
- fixtures/conformance/warning-enum-normalize-ambiguous
- input
- server
- csharp/MetaObjects
- Loader
- java
- metadata/src/main/java/com/metaobjects
- loader
- util
- render/src/main/java/com/metaobjects/render/extract
- python/src/metaobjects/loader
- typescript/packages/metadata
- src
- core/field
- loader
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
13 | 42 | | |
14 | 43 | | |
15 | 44 | | |
| |||
Lines changed: 15 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
Lines changed: 19 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
Lines changed: 18 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
224 | 224 | | |
225 | 225 | | |
226 | 226 | | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
227 | 237 | | |
228 | 238 | | |
229 | 239 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
566 | 566 | | |
567 | 567 | | |
568 | 568 | | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
569 | 581 | | |
570 | 582 | | |
571 | 583 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2960 | 2960 | | |
2961 | 2961 | | |
2962 | 2962 | | |
| 2963 | + | |
| 2964 | + | |
| 2965 | + | |
| 2966 | + | |
| 2967 | + | |
| 2968 | + | |
| 2969 | + | |
| 2970 | + | |
| 2971 | + | |
| 2972 | + | |
| 2973 | + | |
| 2974 | + | |
| 2975 | + | |
| 2976 | + | |
| 2977 | + | |
| 2978 | + | |
| 2979 | + | |
| 2980 | + | |
| 2981 | + | |
| 2982 | + | |
| 2983 | + | |
| 2984 | + | |
| 2985 | + | |
| 2986 | + | |
| 2987 | + | |
| 2988 | + | |
| 2989 | + | |
| 2990 | + | |
| 2991 | + | |
| 2992 | + | |
| 2993 | + | |
| 2994 | + | |
| 2995 | + | |
| 2996 | + | |
| 2997 | + | |
| 2998 | + | |
| 2999 | + | |
| 3000 | + | |
| 3001 | + | |
| 3002 | + | |
| 3003 | + | |
| 3004 | + | |
| 3005 | + | |
| 3006 | + | |
| 3007 | + | |
| 3008 | + | |
| 3009 | + | |
| 3010 | + | |
| 3011 | + | |
| 3012 | + | |
| 3013 | + | |
| 3014 | + | |
| 3015 | + | |
| 3016 | + | |
| 3017 | + | |
| 3018 | + | |
| 3019 | + | |
| 3020 | + | |
| 3021 | + | |
| 3022 | + | |
| 3023 | + | |
| 3024 | + | |
| 3025 | + | |
| 3026 | + | |
| 3027 | + | |
| 3028 | + | |
| 3029 | + | |
| 3030 | + | |
| 3031 | + | |
| 3032 | + | |
| 3033 | + | |
| 3034 | + | |
| 3035 | + | |
| 3036 | + | |
| 3037 | + | |
| 3038 | + | |
| 3039 | + | |
| 3040 | + | |
| 3041 | + | |
| 3042 | + | |
| 3043 | + | |
| 3044 | + | |
| 3045 | + | |
| 3046 | + | |
| 3047 | + | |
| 3048 | + | |
| 3049 | + | |
| 3050 | + | |
| 3051 | + | |
| 3052 | + | |
| 3053 | + | |
| 3054 | + | |
| 3055 | + | |
| 3056 | + | |
| 3057 | + | |
| 3058 | + | |
| 3059 | + | |
| 3060 | + | |
| 3061 | + | |
| 3062 | + | |
| 3063 | + | |
| 3064 | + | |
| 3065 | + | |
| 3066 | + | |
| 3067 | + | |
| 3068 | + | |
| 3069 | + | |
| 3070 | + | |
| 3071 | + | |
| 3072 | + | |
| 3073 | + | |
| 3074 | + | |
| 3075 | + | |
| 3076 | + | |
| 3077 | + | |
| 3078 | + | |
| 3079 | + | |
| 3080 | + | |
| 3081 | + | |
| 3082 | + | |
| 3083 | + | |
| 3084 | + | |
| 3085 | + | |
| 3086 | + | |
| 3087 | + | |
| 3088 | + | |
| 3089 | + | |
| 3090 | + | |
| 3091 | + | |
2963 | 3092 | | |
2964 | 3093 | | |
2965 | 3094 | | |
| |||
0 commit comments