diff --git a/packages/react-native-nitro-sqlite/src/operations/session.ts b/packages/react-native-nitro-sqlite/src/operations/session.ts index f28236ec..a375d634 100644 --- a/packages/react-native-nitro-sqlite/src/operations/session.ts +++ b/packages/react-native-nitro-sqlite/src/operations/session.ts @@ -148,9 +148,8 @@ export function open( ), detach: (alias: string) => runSyncOperation(() => HybridNitroSQLite.detach(connectionId, alias)), - transaction: async ( - fn: (tx: Transaction) => Promise, - ) => runOperation(() => transaction(connectionId, fn, false, queueKey)), + transaction: (fn: (tx: Transaction) => Promise) => + runAsyncOperation(() => transaction(connectionId, fn, false, queueKey)), execute: ( query: string, params?: SQLiteQueryParams, diff --git a/packages/react-native-nitro-sqlite/src/operations/transaction.ts b/packages/react-native-nitro-sqlite/src/operations/transaction.ts index 0c617ade..c299a8bc 100644 --- a/packages/react-native-nitro-sqlite/src/operations/transaction.ts +++ b/packages/react-native-nitro-sqlite/src/operations/transaction.ts @@ -1,4 +1,4 @@ -import { queueOperationAsync, throwIfDatabaseIsNotOpen } from '../DatabaseQueue' +import { queueOperationAsync } from '../DatabaseQueue' import type { Transaction, SQLiteQueryParams, @@ -28,14 +28,12 @@ import type { DatabaseQueueKey } from '../DatabaseQueue' * @returns The callback's result after the transaction finishes. * @throws NitroSQLiteError if BEGIN, the callback, COMMIT, or ROLLBACK fails. */ -export const transaction = async ( +export const transaction = ( dbName: string, transactionCallback: (tx: Transaction) => Promise, isExclusive = false, queueKey: DatabaseQueueKey = dbName, -) => { - throwIfDatabaseIsNotOpen(queueKey) - +): Promise => { const state: { current: TransactionState } = { current: { kind: 'notStarted' }, } @@ -143,7 +141,9 @@ export const transaction = async ( } } - return await queueOperationAsync(queueKey, async () => { + // Only the callback below needs `async`; wrapping the queue too would add promise layers. + // The queue rejects when the database is not open. + return queueOperationAsync(queueKey, async () => { try { await executeAsyncNative( dbName,