Maps/Vmaps and MMaps Digit change by billy1arm · Pull Request #360 · mangoszero/server

billy1arm · 2026-06-08T20:42:49Z

all files will need to be extracted after this update

This change is

codacy-production · 2026-06-08T20:43:35Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results

Complexity 0

Duplication 0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

Copilot

Pull request overview

Updates map/vmap/mmap file naming conventions to use 4-digit zero-padded map IDs (e.g., 0001 instead of 001) across runtime loaders, generators, and GM commands to align with updated extraction outputs.

Changes:

Switched mmap .mmap and .mmtile filename formatting from 3-digit to 4-digit map IDs.
Switched terrain .map filename formatting from 3-digit to 4-digit map IDs.
Switched vmap .vmtree/.vmtile filename formatting from 3-digit to 4-digit map IDs.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
`src/game/WorldHandlers/MoveMap.cpp`	Updates mmap `.mmap`/`.mmtile` filename patterns and related logs to 4-digit map IDs.
`src/game/WorldHandlers/GridMap.cpp`	Updates terrain `.map` filename patterns to 4-digit map IDs.
`src/game/vmap/VMapManager2.cpp`	Updates vmap runtime map tree filename padding to 4 digits.
`src/game/vmap/TileAssembler.cpp`	Updates vmap extractor output filenames (`.vmtree`/`.vmtile`) to 4 digits.
`src/game/vmap/MapTree.cpp`	Updates vmap tile filename generation to 4 digits.
`src/game/ChatCommands/MMapCommands.cpp`	Updates `.mmap loc` output formatting to 4-digit map IDs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

AppVeyorBot · 2026-06-08T21:42:22Z

✅ Build Mangos ZERO Server 22.04.317-shxjatpe completed (commit fc4d4d67de by @billy1arm)

AppVeyorBot · 2026-06-09T06:54:19Z

✅ Build Mangos ZERO Server 22.04.317-obejvsvb completed (commit c84193da85 by @billy1arm)

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

            {
                --loadedTiles;
-                DEBUG_FILTER_LOG(LOG_FILTER_MAP_LOADING, "MMAP:unloadMap: Unloaded mmtile %03i[%02i,%02i] from %03i", mapId, x, y, mapId);
+                DEBUG_FILTER_LOG(LOG_FILTER_MAP_LOADING, "MMAP:unloadMap: Unloaded mmtile %04u[%02i,%02i] from %04i", mapId, x, y, mapId);


+    int len = sWorld.GetDataPath().length() + strlen("maps/%04u%02u%02u.map") + 1;
    char* tmp = new char[len];
-    snprintf(tmp, len, (char*)(sWorld.GetDataPath() + "maps/%03u%02u%02u.map").c_str(), mapid, gx, gy);
+    snprintf(tmp, len, (char*)(sWorld.GetDataPath() + "maps/%04u%02u%02u.map").c_str(), mapid, (unsigned)gx, (unsigned)gy);


AppVeyorBot · 2026-06-09T09:24:10Z

❌ Build Mangos ZERO Server 22.04.317-boywljkw failed (commit 7c3a04f345 by @billy1arm)

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

            {
                --loadedTiles;
-                DEBUG_FILTER_LOG(LOG_FILTER_MAP_LOADING, "MMAP:unloadMap: Unloaded mmtile %03i[%02i,%02i] from %03i", mapId, x, y, mapId);
+                DEBUG_FILTER_LOG(LOG_FILTER_MAP_LOADING, "MMAP:unloadMap: Unloaded mmtile %04u[%02i,%02i] from %04i", mapId, x, y, mapId);


+        const int32 filenameTileY = y;

-        // load this tile :: mmaps/MMMYYXX.mmtile
+        // load this tile :: mmaps/MMMXXYY.mmtile


+    int len = sWorld.GetDataPath().length() + strlen("maps/%04u%02u%02u.map") + 1;
    char* tmp = new char[len];
-    snprintf(tmp, len, (char*)(sWorld.GetDataPath() + "maps/%03u%02u%02u.map").c_str(), mapid, gx, gy);
+    snprintf(tmp, len, (char*)(sWorld.GetDataPath() + "maps/%04u%02u%02u.map").c_str(), mapid, (unsigned)gx, (unsigned)gy);


+            int len = sWorld.GetDataPath().length() + strlen("maps/%04u%02u%02u.map") + 1;
            char* tmp = new char[len];
-            snprintf(tmp, len, (char*)(sWorld.GetDataPath() + "maps/%03u%02u%02u.map").c_str(), m_mapId, x, y);
+            snprintf(tmp, len, (char*)(sWorld.GetDataPath() + "maps/%04u%02u%02u.map").c_str(), m_mapId, x, y);


AppVeyorBot · 2026-06-09T12:04:17Z

❌ Build Mangos ZERO Server 22.04.317-anbeyyed failed (commit 7954006792 by @billy1arm)

Maps/Vmaps and MMaps Digit change

609a02d

Copilot AI review requested due to automatic review settings June 8, 2026 20:42

Copilot started reviewing on behalf of billy1arm June 8, 2026 20:42 View session

Copilot AI reviewed Jun 8, 2026

View reviewed changes

Some more x, y transposed

35d0341

Change format specifiers from %i to %u for mapId

58e444a

Copilot AI review requested due to automatic review settings June 9, 2026 08:15

Copilot started reviewing on behalf of billy1arm June 9, 2026 08:15 View session

Potential fix for pull request finding

6e95c3a

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Potential fix for pull request finding

f8bd748

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 9, 2026 08:20

Copilot started reviewing on behalf of billy1arm June 9, 2026 08:20 View session

billy1arm and others added 3 commits June 9, 2026 09:21

Potential fix for pull request finding

3fd316b

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

b783d1f

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

3d0602f

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Potential fix for pull request finding

da60982

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 9, 2026 11:01

Copilot started reviewing on behalf of billy1arm June 9, 2026 11:01 View session

Potential fix for pull request finding

c05a790

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Conversation

billy1arm commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codacy-production Bot commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Up to standards ✅

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AppVeyorBot commented Jun 8, 2026

Uh oh!

AppVeyorBot commented Jun 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AppVeyorBot commented Jun 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

AppVeyorBot commented Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

billy1arm commented Jun 8, 2026 •

edited

Loading

codacy-production Bot commented Jun 8, 2026 •

edited

Loading