diff --git a/src/Core/Meeting.php b/src/Core/Meeting.php index 84d24ded..d087ff28 100644 --- a/src/Core/Meeting.php +++ b/src/Core/Meeting.php @@ -37,7 +37,7 @@ class Meeting private readonly string $creationDate; - private readonly int $voiceBridge; + private readonly string $voiceBridge; private readonly string $dialNumber; @@ -86,7 +86,7 @@ public function __construct(protected \SimpleXMLElement $rawXml) $this->meetingName = $this->rawXml->meetingName->__toString(); $this->creationTime = (float) $this->rawXml->createTime; $this->creationDate = $this->rawXml->createDate->__toString(); - $this->voiceBridge = (int) $this->rawXml->voiceBridge; + $this->voiceBridge = $this->rawXml->voiceBridge->__toString(); $this->dialNumber = $this->rawXml->dialNumber->__toString(); $this->hasBeenForciblyEnded = $this->rawXml->hasBeenForciblyEnded->__toString() === 'true'; $this->isRunning = $this->rawXml->running->__toString() === 'true'; @@ -126,7 +126,7 @@ public function getCreationDate(): string return $this->creationDate; } - public function getVoiceBridge(): int + public function getVoiceBridge(): string { return $this->voiceBridge; } diff --git a/src/Parameters/CreateMeetingParameters.php b/src/Parameters/CreateMeetingParameters.php index 8e00d7ae..b58446eb 100644 --- a/src/Parameters/CreateMeetingParameters.php +++ b/src/Parameters/CreateMeetingParameters.php @@ -36,8 +36,8 @@ * @method $this setWelcome(string $welcome) * @method string getDialNumber() * @method $this setDialNumber(string $dialNumber) - * @method int getVoiceBridge() - * @method $this setVoiceBridge(int $voiceBridge) + * @method string getVoiceBridge() + * @method $this setVoiceBridge(string $voiceBridge) * @method string getWebVoice() * @method $this setWebVoice(string $webVoice) * @method int getMaxParticipants() @@ -167,7 +167,7 @@ class CreateMeetingParameters extends MetaParameters { protected ?string $welcome = null; protected ?string $dialNumber = null; - protected ?int $voiceBridge = null; + protected ?string $voiceBridge = null; protected ?string $webVoice = null; protected ?int $maxParticipants = null; protected ?string $loginURL = null; diff --git a/src/Responses/CreateMeetingResponse.php b/src/Responses/CreateMeetingResponse.php index 2c5f350a..fb7bfd13 100644 --- a/src/Responses/CreateMeetingResponse.php +++ b/src/Responses/CreateMeetingResponse.php @@ -55,9 +55,9 @@ public function getCreationTime(bool $milliseconds = true) return $milliseconds ? (float) $this->rawXml->createTime : (int) ($this->rawXml->createTime / 1000); } - public function getVoiceBridge(): int + public function getVoiceBridge(): string { - return (int) $this->rawXml->voiceBridge; + return $this->rawXml->voiceBridge->__toString(); } public function getDialNumber(): string diff --git a/tests/common/TestCase.php b/tests/common/TestCase.php index 19c792fc..85376e93 100644 --- a/tests/common/TestCase.php +++ b/tests/common/TestCase.php @@ -64,7 +64,7 @@ protected function generateCreateParams(): array 'meetingID' => $this->faker->uuid, 'autoStartRecording' => $this->faker->boolean(50), 'dialNumber' => $this->faker->phoneNumber, - 'voiceBridge' => $this->faker->randomNumber(5, true), + 'voiceBridge' => $this->faker->numerify('#####'), 'webVoice' => $this->faker->word, 'logoutURL' => $this->faker->url, 'maxParticipants' => $this->faker->numberBetween(2, 100), diff --git a/tests/fixtures/create_meeting.xml b/tests/fixtures/create_meeting.xml index 889cc184..28ece701 100644 --- a/tests/fixtures/create_meeting.xml +++ b/tests/fixtures/create_meeting.xml @@ -6,7 +6,7 @@ tK6J5cJv3hMLNx5IBePa 34Heu0uiZYqCZXX9C4m2 1453283819419 - 76286 + 06286 613-555-1234 Wed Jan 20 04:56:59 EST 2016 false diff --git a/tests/unit/BigBlueButtonTest.php b/tests/unit/BigBlueButtonTest.php index 944639c9..c08f8f46 100644 --- a/tests/unit/BigBlueButtonTest.php +++ b/tests/unit/BigBlueButtonTest.php @@ -407,7 +407,7 @@ public function testGetMeetings(): void 12345 1531241258036 Tue Jul 10 16:47:38 UTC 2018 - 70066 + 07066 613-555-1234 ap mp @@ -441,7 +441,7 @@ public function testGetMeetings(): void $this->assertEquals('12345', $response->getMeetings()[0]->getInternalMeetingId()); $this->assertEquals(1531241258036, $response->getMeetings()[0]->getCreationTime()); $this->assertEquals('Tue Jul 10 16:47:38 UTC 2018', $response->getMeetings()[0]->getCreationDate()); - $this->assertEquals(70066, $response->getMeetings()[0]->getVoiceBridge()); + $this->assertEquals('07066', $response->getMeetings()[0]->getVoiceBridge()); $this->assertEquals('613-555-1234', $response->getMeetings()[0]->getDialNumber()); $this->assertFalse($response->getMeetings()[0]->isRunning()); $this->assertEquals(0, $response->getMeetings()[0]->getDuration()); diff --git a/tests/unit/Responses/CreateMeetingResponseTest.php b/tests/unit/Responses/CreateMeetingResponseTest.php index 6d5d40f2..5f0f0749 100644 --- a/tests/unit/Responses/CreateMeetingResponseTest.php +++ b/tests/unit/Responses/CreateMeetingResponseTest.php @@ -48,7 +48,7 @@ public function testCreateMeetingResponseContent(): void $this->assertEquals('1a6938c707cdf5d052958672d66c219c30690c47-1524212045514', $this->meeting->getInternalMeetingId()); $this->assertEquals('bbb-none', $this->meeting->getParentMeetingId()); $this->assertEquals(1453283819419, $this->meeting->getCreationTime()); - $this->assertEquals(76286, $this->meeting->getVoiceBridge()); + $this->assertEquals('06286', $this->meeting->getVoiceBridge()); $this->assertEquals('Wed Jan 20 04:56:59 EST 2016', $this->meeting->getCreationDate()); $this->assertEquals('613-555-1234', $this->meeting->getDialNumber()); $this->assertFalse($this->meeting->hasUserJoined()); @@ -65,10 +65,10 @@ public function testCreateMeetingResponseTypes(): void { $this->assertEachGetterValueIsString($this->meeting, [ 'getReturnCode', 'getInternalMeetingId', 'getParentMeetingId', - 'getDialNumber', 'getCreationDate', + 'getDialNumber', 'getVoiceBridge', 'getCreationDate', ]); $this->assertEachGetterValueIsDouble($this->meeting, ['getCreationTime']); - $this->assertEachGetterValueIsInteger($this->meeting, ['getDuration', 'getVoiceBridge']); + $this->assertEachGetterValueIsInteger($this->meeting, ['getDuration']); $this->assertEachGetterValueIsBoolean($this->meeting, ['hasUserJoined', 'hasBeenForciblyEnded']); } diff --git a/tests/unit/Responses/GetMeetingInfoResponseTest.php b/tests/unit/Responses/GetMeetingInfoResponseTest.php index 6ab4e8fd..fbc9626c 100644 --- a/tests/unit/Responses/GetMeetingInfoResponseTest.php +++ b/tests/unit/Responses/GetMeetingInfoResponseTest.php @@ -125,11 +125,11 @@ public function testGetMeetingInfoResponseTypes(): void $this->assertEachGetterValueIsString($info, [ 'getMeetingName', 'getMeetingId', 'getInternalMeetingId', - 'getCreationDate', 'getDialNumber', + 'getCreationDate', 'getDialNumber', 'getVoiceBridge', ]); $this->assertEachGetterValueIsInteger($info, [ - 'getVoiceBridge', 'getDuration', 'getParticipantCount', + 'getDuration', 'getParticipantCount', 'getListenerCount', 'getVoiceParticipantCount', 'getVideoCount', 'getMaxUsers', 'getModeratorCount', ]); diff --git a/tests/unit/Responses/GetMeetingsResponseTest.php b/tests/unit/Responses/GetMeetingsResponseTest.php index f39df44a..fc3d2c31 100644 --- a/tests/unit/Responses/GetMeetingsResponseTest.php +++ b/tests/unit/Responses/GetMeetingsResponseTest.php @@ -72,10 +72,10 @@ public function testGetMeetingsResponseTypes(): void $aMeeting = $this->meetings->getMeetings()[2]; - $this->assertEachGetterValueIsString($aMeeting, ['getMeetingId', 'getMeetingName', 'getCreationDate', 'getDialNumber']); + $this->assertEachGetterValueIsString($aMeeting, ['getMeetingId', 'getMeetingName', 'getCreationDate', 'getDialNumber', 'getVoiceBridge']); $this->assertEachGetterValueIsDouble($aMeeting, ['getCreationTime']); $this->assertEachGetterValueIsInteger($aMeeting, [ - 'getVoiceBridge', 'getParticipantCount', 'getListenerCount', + 'getParticipantCount', 'getListenerCount', 'getVoiceParticipantCount', 'getVideoCount', 'getDuration', ]); $this->assertEachGetterValueIsBoolean($aMeeting, ['hasBeenForciblyEnded', 'isRunning', 'hasUserJoined']);