[BUG] Keyboard randomly acts like it is holding down shift all the time

[thefunkygibbon]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

When using webtop it will randomly start making all text capitals, won't press enter normally, and clicking anything ends up opening a new window etc as is the norm if you held shift down.,

Expected Behavior

not to do the above

Steps To Reproduce

use it, there isn't any rhyme or reason why it starts doing it.

Environment

debian, docker compose

CPU architecture

x86-64

Docker creation

can't get this right now, but i don't think its relevant.

Container logs

nothing of note in the logs

[github-actions]

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

[thefunkygibbon]

ok i think i have some more info, it appears to do it if i press right shift and "some keys" .. it seems to lock down that shift as being constantly pressed. I can "undo" that by pressing left shift and one of those keys.

"some keys" seems to be any key except the letter keys. so numbers and any symbol key

[thelamer]

Input is a complex beast, a lot of the stuff you are describing revolves around modifier handling and it is written this way in order to support every language in the world seamlessly.

https://github.com/selkies-project/selkies/blob/main/src/selkies/input_handler.py

So while I understand you might get stuck keys every once and a while this is the best I can do right now and this has been iterated on from feedback from many different language speakers.

If you see obvious ways to fix this while still testing IME input, swiss(this one is always a stickler as it uses tons of modifiers depending on dialect) , french, german, and russian.

Basically the entire keyboard you interact with in the browser sends us keysyms and unicode hex codes and we have to turn that into a native experience, it is not like a scancode translation layer which would require users to install and set their keyboard layout on init for the remote container and would still have browser issues with modifier keys.

[thefunkygibbon]

Well as i say, it "seems" to be only when i right-shift certain keys. and since i'm used to pressing the shift of whichever hand the key that is being typed is using at the time its rather hard to "untrain" myself to do that just to use webtop it's like undoing 40 years of muscle memory :-D

I can't really advise on any routes to resolve this and I appreciate that it must be a tricky thing to handle. So I can only hope that the specific description of what seems to be causing it might help.

(UK ISO keyboard layout fwiw)

Thanks for your work on this system though. Whilst I miss KASM, this is great too.

[thelamer]

Linking selkies-project/selkies#214

Just in general Input is on my radar, but it needs a refactor/test methods and I am focused on other parts of the stack right now.

It is not my favorite part of the codebase as with this universal support method (capturing modifiers and unicode keysyms in the browser and translating them to an english keyboard on the server) you have all these oddities and workarounds.

The problem stems from the whack a mole development where squashing a bug for a specific language or client might cause an issue with another language or client.

[thelamer]

Are you running OSX? selkies-project/selkies@cf289a8

[thefunkygibbon]

nah, windows 11 mostly. i have an old macmini kicking about somewhere if you need me to fire it up to test (OS will be old though comparatively as its an i7 based one and i dont think they've allowed the last few versions of macos to be installed on them.

[ch4ox]

Just wanted to let you know, I have the same problem here with German settings. Right shift somehow "sticks". This issue is kinda new though, I don't remember having this problem a few versions back and I update my container on a regular basis. Pretty sure this was Selkies back then, too, hm...

[MarkStephan89]

hi,
I have the same problems (german layout)
The shift key stick and the left mouse is the same with the right mouse -.-

I use win11

//edit: e.g. I write "d" and "D" is pressed, I use shift and then "d" is "d" --> all ok
after a few writing the shift is stick again -.-

[LinuxServer-CI]

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

[akshun-j]

Bot tagged this as stale, but issue continues