From cc4312a736b94db5cced6bdf16f59b1cd0fb38fb Mon Sep 17 00:00:00 2001 From: Valentine Wallace Date: Fri, 26 Jun 2026 10:44:17 -0400 Subject: [PATCH 1/2] Fuzz: remove unnecessary route_params clones --- fuzz/src/chanmon_consistency.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fuzz/src/chanmon_consistency.rs b/fuzz/src/chanmon_consistency.rs index b0703d8e6ed..273af2a021f 100644 --- a/fuzz/src/chanmon_consistency.rs +++ b/fuzz/src/chanmon_consistency.rs @@ -1866,7 +1866,7 @@ impl PaymentTracker { }], blinded_tail: None, }], - route_params: route_params.clone(), + route_params, }; let onion = RecipientOnionFields::secret_only(secret, amt); let res = source.send_payment_with_route(route, hash, onion, id); @@ -1946,7 +1946,7 @@ impl PaymentTracker { ], blinded_tail: None, }], - route_params: route_params.clone(), + route_params, }; let onion = RecipientOnionFields::secret_only(secret, amt); let res = source.send_payment_with_route(route, hash, onion, id); From 47f58f34af4e53ec6c8f3598ee6d6198d73194e7 Mon Sep 17 00:00:00 2001 From: Valentine Wallace Date: Fri, 26 Jun 2026 10:44:17 -0400 Subject: [PATCH 2/2] Set max fee in route params for probes May as well, and allows removing a comment that explains why we were previously leaving it as None. --- lightning/src/ln/outbound_payment.rs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lightning/src/ln/outbound_payment.rs b/lightning/src/ln/outbound_payment.rs index 105ee355a9e..20b594a1e83 100644 --- a/lightning/src/ln/outbound_payment.rs +++ b/lightning/src/ln/outbound_payment.rs @@ -1922,9 +1922,6 @@ impl OutboundPayments { })) } - // `route_params` is a required field, but is unused when sending a probe along a fixed - // path. Construct dummy parameters from the path, leaving the fee budget unset to match - // the previous behavior of not tracking one for probes. let route_params = { let last_hop = path.hops.last().unwrap(); let payment_params = @@ -1932,7 +1929,7 @@ impl OutboundPayments { RouteParameters { payment_params, final_value_msat: path.final_value_msat(), - max_total_routing_fee_msat: None, + max_total_routing_fee_msat: Some(path.fee_msat()), } }; let route = Route { paths: vec![path], route_params };