Skip to content

Follow-ups to PR #658 #770

@tnull

Description

@tnull

In #658 we switched to use BDK wallet events to update the payment store and introduced a new 'pending payement store'. We merged the PR, though here are some follow-ups I want to address before the next release:

  • io/mod.rs: Move persistence consts up to other payment consts
  • DRY up read_ method
  • Don't expose PendingPaymentDetails in public API
  • Move PendingPaymentStore to payment_store.rs
  • Make conflicting_txids a Vec rather than Option<Vec<>>
  • Not convinced we need to track entire PaymentDetails in the pending store, plus semantically it doens't make sense to track conflicts for BOLT11 payments for example. Maybe there is another way?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions