Parse SDL headers from EMSDK during Pyodide builds

Try not to bundle win/mac binaries during Pyodide build

Author: HexDecimal

.github/workflows/python-package.yml

@@ -330,11 +330,6 @@ jobs:
           fetch-depth: ${{ env.git-depth }}
       - name: Checkout submodules
         run: git submodule update --init --recursive --depth 1
-      - uses: libsdl-org/setup-sdl@6574e20ac65ce362cd12f9c26b3a5e4d3cd31dee
-        with:
-          install-linux-dependencies: true
-          build-type: "Debug"
-          version: ${{ env.sdl-version }}
       - uses: pypa/cibuildwheel@v3.0.0
         env:
           CIBW_PLATFORM: pyodide

build_sdl.py

@@ -251,14 +251,18 @@ def on_directive_handle(
 
 check_sdl_version()
 
-if sys.platform == "win32" or sys.platform == "darwin":
+SDL_PARSE_PATH: Path | None = None
+SDL_BUNDLE_PATH: Path | None = None
+if (sys.platform == "win32" or sys.platform == "darwin") and "PYODIDE" not in os.environ:
     SDL_PARSE_PATH = unpack_sdl(SDL_PARSE_VERSION)
     SDL_BUNDLE_PATH = unpack_sdl(SDL_BUNDLE_VERSION)
 
 SDL_INCLUDE: Path
-if sys.platform == "win32":
+if "PYODIDE" in os.environ:
+    SDL_INCLUDE = Path(os.environ["EMSDK"], "include")
+elif sys.platform == "win32" and SDL_PARSE_PATH is not None:
     SDL_INCLUDE = SDL_PARSE_PATH / "include"
-elif sys.platform == "darwin":
+elif sys.platform == "darwin" and SDL_PARSE_PATH is not None:
     SDL_INCLUDE = SDL_PARSE_PATH / "Versions/A/Headers"
 else:  # Unix
     matches = re.findall(
@@ -275,6 +279,7 @@ def on_directive_handle(
         raise AssertionError(matches)
     assert SDL_INCLUDE
 
+logger.info(f"{SDL_INCLUDE=}")
 
 EXTRA_CDEF = """
 #define SDLK_SCANCODE_MASK ...
@@ -358,7 +363,7 @@ def get_cdef() -> tuple[str, dict[str, str]]:
     libraries += ["SDL3"]
 
 # Bundle the Windows SDL DLL.
-if sys.platform == "win32":
+if sys.platform == "win32" and SDL_BUNDLE_PATH is not None:
     include_dirs.append(str(SDL_INCLUDE))
     ARCH_MAPPING = {"32bit": "x86", "64bit": "x64"}
     SDL_LIB_DIR = Path(SDL_BUNDLE_PATH, "lib/", ARCH_MAPPING[BIT_SIZE])
@@ -372,7 +377,7 @@ def get_cdef() -> tuple[str, dict[str, str]]:
 
 # Link to the SDL framework on MacOS.
 # Delocate will bundle the binaries in a later step.
-if sys.platform == "darwin":
+if sys.platform == "darwin" and SDL_BUNDLE_PATH is not None:
     include_dirs.append(SDL_INCLUDE)
     extra_link_args += [f"-F{SDL_BUNDLE_PATH}/.."]
     extra_link_args += ["-rpath", f"{SDL_BUNDLE_PATH}/.."]