Use correct Device Model Identifier

[ABausG]

Describe the bug

The Launchdarkly Website states that Device / Model Context is providing a value like:
iPhone10,3

for device model.

model	Model of the device.	Pixel 6 Pro, iPhone, iPhone10,3, iPad

However this is not true for the Flutter SDK as that will always just report "iPhone" as it is using info.model from device_info_plus

flutter-client-sdk/packages/flutter_client_sdk/lib/src/platform_env_reporter.dart

Lines 100 to 101 in 0dd2106

	final info = await DeviceInfoPlugin().iosInfo;
	return DeviceInfo(model: info.model, manufacturer: 'Apple');

https://pub.dev/documentation/device_info_plus/latest/device_info_plus/IosDeviceInfo/model.html
https://developer.apple.com/documentation/uikit/uidevice/model

Instead the utsname.machine should be used for this:
https://pub.dev/documentation/device_info_plus/latest/device_info_plus/IosUtsname/machine.html

To reproduce
Use the SDK on an iPhone
Observer that the device.model is just "iPhone"

Expected behavior
device.model should include the actual device type
alternatively add a new field

Important

Otherwise targetting iPhones by Model is not possible

Logs

SDK version
4.14.0

OS/platform
iOS

Additional context
See the output from DeviceInfoPlus

[kinyoklion]

Hello @ABausG,

Thank you for reporting the issue, and we will look into if we can reasonably make the change. Other customers may be using this SDK and targeting by iPhone, so it cannot be changed without consideration. It is also always possible to replace the context, or add additional data to another context kind to get the level of granularity you want.

It is expected that the detail level is SDK/ecosystem specific. The examples are not a specification of the data itself, but one of the examples is also just iPhone (the second item in the list).

I agree it would have probably been best for us to use the machine ID originally.

Thank you,
Ryan

Filed internally as SDK-1656

[ABausG]

I absolutetely see that simply changing this would be a breaking change that is not really easy to understand the impact.

My proposal would be:

A new "machineName" on the device context that would:

on iOS be the machine Id
on other platforms it would match the current name

We would greatly appreciate it if this could be handled in the default device context because the alternative options we see are not ideal

• rebuild the device context ourselves -> Risk of missing something/not get changes
• add a new context -> This would polute our context and create segmentation in our setup

---

I'd be happy to make this contribution if you give me the thumbs up

[ABausG]

Hey. Just checking back in :)

Can you give me an update on if my proposal would be considered to add this as a new field? For machineName

[ABausG]

@kinyoklion gentle ping. As stated I'd be happy to create a PR with this addition if this is something you would consider to support

[kinyoklion]

Hello @ABausG,

Sorry for missing your reply.

I don't have a good answer for you at this time. I'll raise it in internal discussion again. Adding a new field would likely not be a path we would want, unless we could provide some meaning to that field in all of the client-side SDKs that support automatic environment attributes. Its more likely we would want to update what this field contains, but may still have to limit such a change to a major version

Thank you,
Ryan

[kinyoklion]

Hello @ABausG,

Thanks again for bringing this to our attention. If you are still interested in contributing a PR, how would you feel about something like {apple: {machineId: 'the-id'} versus just machineId. It looks like we may want to scope this change to be apple specific. Our iOS SDK currently has the same granularity as flutter, so we could also eventually extend it with the same information.

Thank you,
Ryan