improved comments

grdanny · grdanny · commit 871e5d54d3c3 · 2026-02-22T16:14:39.000-08:00
diff --git a/pystring_impl.h b/pystring_impl.h
@@ -577,7 +577,7 @@ const std::string colon = ":";
     bool isupper(const std::string &str)
     {
         // this is written this way to match python's behavior of isupper
-        // in python something like HELLO! (the "!") is basically ignored
+        // in python something like "HELLO!" returns true (the "!" is basically ignored)
         bool has_cased = false;
         for (std::string::size_type i = 0; i < str.size(); ++i)
         {

Original file line number	Diff line number	Diff line change
`@@ -577,7 +577,7 @@ const std::string colon = ":";`
`577`	`577`	`bool isupper(const std::string &str)`
`578`	`578`	`{`
`579`	`579`	`// this is written this way to match python's behavior of isupper`
`580`		`- // in python something like HELLO! (the "!") is basically ignored`
	`580`	`+ // in python something like "HELLO!" returns true (the "!" is basically ignored)`
`581`	`581`	`bool has_cased = false;`
`582`	`582`	`for (std::string::size_type i = 0; i < str.size(); ++i)`
`583`	`583`	`{`