You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You've targeted the master branch with this PR. Please consider if a version branch might be more appropriate:
maintenance-9.x - If your change is backward-compatible and won't create compatibility issues between INAV firmware and Configurator 9.x versions. This will allow your PR to be included in the next 9.x release.
maintenance-10.x - If your change introduces compatibility requirements between firmware and configurator that would break 9.x compatibility. This is for PRs which will be included in INAV 10.x
If master is the correct target for this change, no action is needed.
This is an automated suggestion to help route contributions to the appropriate branch.
1 targets built. Find your board's .hex file by name on that page (e.g. MATEKF405SE.hex). Files are individually downloadable — no GitHub login required.
Development build for testing only. Use Full Chip Erase when flashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
This PR fixes missing ESC telemetry on
JHEMCUF435by correcting the FC target UART configuration and adding target default serial mapping.Root cause
This issue exists on both sides of the telemetry path:
ESC firmware side (AM32)
A related fix is here: f421: honor USE_PA14_TELEMETRY for serial telemetry am32-firmware/AM32#373
That PR addresses the ESC-side (all target that using MCU AT32F421 with telemetry at PA14) telemetry issue.
FC firmware side (this PR)
The
JHEMCUF435target was missing:USE_UART7_PIN_SWAPAs a result,
ESCSERIALcould be configured logically, but UART7 was still routed to the wrong physical pins for this board.What this PR changes
1. Fix UART7 pin routing for
JHEMCUF435Adds:
#define USE_UART7_PIN_SWAPThis ensures UART7 uses the correct physical routing for ESC telemetry on this target.
2. Add default target serial configuration
Adds a target
config.cso this board comes up with sane defaults:RX_SERIAL -> USART2ESCSERIAL -> USART7This avoids requiring manual remapping after flashing and makes the target work correctly out of the box for this wiring layout.
Why both fixes matter
Telemetry was blocked by a combination of:
Fixing only one side is not sufficient for a complete working telemetry path.
Validation
With:
AM32#373ESC telemetry is now received correctly through the FC and is forwarded successfully to the TX.