Skip to content

target/JHEMCUF435: fix UART7 ESC telemetry defaults#11641

Open
dtrbinh wants to merge 1 commit into
iNavFlight:masterfrom
dtrbinh:fix/jhemcuf435-uart7-missing-swap
Open

target/JHEMCUF435: fix UART7 ESC telemetry defaults#11641
dtrbinh wants to merge 1 commit into
iNavFlight:masterfrom
dtrbinh:fix/jhemcuf435-uart7-missing-swap

Conversation

@dtrbinh

@dtrbinh dtrbinh commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

PR Description

Summary

This PR fixes missing ESC telemetry on JHEMCUF435 by correcting the FC target UART configuration and adding target default serial mapping.

Root cause

This issue exists on both sides of the telemetry path:

  1. ESC firmware side (AM32)
    A related fix is here: f421: honor USE_PA14_TELEMETRY for serial telemetry am32-firmware/AM32#373
    That PR addresses the ESC-side (all target that using MCU AT32F421 with telemetry at PA14) telemetry issue.

  2. FC firmware side (this PR)
    The JHEMCUF435 target was missing:

    • USE_UART7_PIN_SWAP

    As a result, ESCSERIAL could be configured logically, but UART7 was still routed to the wrong physical pins for this board.

What this PR changes

1. Fix UART7 pin routing for JHEMCUF435

Adds:

  • #define USE_UART7_PIN_SWAP

This ensures UART7 uses the correct physical routing for ESC telemetry on this target.

2. Add default target serial configuration

Adds a target config.c so this board comes up with sane defaults:

  • RX_SERIAL -> USART2
  • ESCSERIAL -> USART7

This avoids requiring manual remapping after flashing and makes the target work correctly out of the box for this wiring layout.

Why both fixes matter

Telemetry was blocked by a combination of:

  • AM32 ESC-side telemetry issue
  • FC-side UART7 swap missing on this target

Fixing only one side is not sufficient for a complete working telemetry path.

Validation

With:

  • the AM32-side fix from AM32#373
  • and the FC target fix in this PR

ESC telemetry is now received correctly through the FC and is forwarded successfully to the TX.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Branch Targeting Suggestion

You've targeted the master branch with this PR. Please consider if a version branch might be more appropriate:

  • maintenance-9.x - If your change is backward-compatible and won't create compatibility issues between INAV firmware and Configurator 9.x versions. This will allow your PR to be included in the next 9.x release.

  • maintenance-10.x - If your change introduces compatibility requirements between firmware and configurator that would break 9.x compatibility. This is for PRs which will be included in INAV 10.x

If master is the correct target for this change, no action is needed.


This is an automated suggestion to help route contributions to the appropriate branch.

@qodo-code-review

Copy link
Copy Markdown
Contributor

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Test firmware build ready — commit c0ba786

Download firmware for PR #11641

1 targets built. Find your board's .hex file by name on that page (e.g. MATEKF405SE.hex). Files are individually downloadable — no GitHub login required.

Development build for testing only. Use Full Chip Erase when flashing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant