Skip to content

pmpp_v2/histogram_py: task.yml description does not match reference.py implementation #140

@pedrozoivan627-web

Description

@pedrozoivan627-web

Hi, thanks for maintaining this repository and the PMPP practice problems.

I noticed a mismatch in problems/pmpp_v2/histogram_py between the task description and the actual implementation.

In task.yml, the description says:

  • the minimum and maximum values are fixed to 0 and 100
  • all sizes are multiples of 16
  • the number of bins is size / 16

However, in reference.py and submission.py, the implementation appears to use:

  • input values in the range [0, 255]
  • a fixed output size of 256 bins
  • torch.bincount(..., minlength=256)

So it seems the current evaluation behavior is based on 256 fixed bins, not size / 16.

Would you mind confirming which behavior is intended?
If helpful, I can also open a PR to update the description for consistency.

Thanks again for the great project.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions