From 0267f3237f2ce61358cab168f1e3f26348121a36 Mon Sep 17 00:00:00 2001 From: Brent Shaffer Date: Wed, 29 Jul 2026 21:03:10 +0000 Subject: [PATCH 1/3] trigger all *-system-tests tests --- handwritten/bigquery-storage/package.json | 1 + handwritten/bigquery/package.json | 1 + handwritten/bigtable/package.json | 1 + handwritten/cloud-profiler/package.json | 1 + handwritten/datastore/package.json | 1 + handwritten/error-reporting/package.json | 1 + handwritten/firestore/package.json | 1 + handwritten/google-cloud-dns/package.json | 1 + handwritten/logging-bunyan/package.json | 1 + handwritten/logging-winston/package.json | 1 + handwritten/logging/package.json | 1 + handwritten/pubsub/package.json | 1 + handwritten/spanner-driver/package.json | 1 + handwritten/spanner/package.json | 1 + handwritten/storage/package.json | 1 + 15 files changed, 15 insertions(+) diff --git a/handwritten/bigquery-storage/package.json b/handwritten/bigquery-storage/package.json index 6d305c2fa072..d858cc5fd89d 100644 --- a/handwritten/bigquery-storage/package.json +++ b/handwritten/bigquery-storage/package.json @@ -70,3 +70,4 @@ }, "homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/bigquery-storage" } + diff --git a/handwritten/bigquery/package.json b/handwritten/bigquery/package.json index 2c1aad583949..cc058646af3e 100644 --- a/handwritten/bigquery/package.json +++ b/handwritten/bigquery/package.json @@ -96,3 +96,4 @@ }, "homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/bigquery" } + diff --git a/handwritten/bigtable/package.json b/handwritten/bigtable/package.json index d5a263eda184..096ed88b12a3 100644 --- a/handwritten/bigtable/package.json +++ b/handwritten/bigtable/package.json @@ -115,3 +115,4 @@ }, "homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/bigtable" } + diff --git a/handwritten/cloud-profiler/package.json b/handwritten/cloud-profiler/package.json index d84294fe12cc..c8e566db71a0 100644 --- a/handwritten/cloud-profiler/package.json +++ b/handwritten/cloud-profiler/package.json @@ -86,3 +86,4 @@ }, "homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/cloud-profiler" } + diff --git a/handwritten/datastore/package.json b/handwritten/datastore/package.json index 64e6853b8669..e98333e8f226 100644 --- a/handwritten/datastore/package.json +++ b/handwritten/datastore/package.json @@ -87,3 +87,4 @@ }, "homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/datastore" } + diff --git a/handwritten/error-reporting/package.json b/handwritten/error-reporting/package.json index f6511ca8f29b..d44289ed95af 100644 --- a/handwritten/error-reporting/package.json +++ b/handwritten/error-reporting/package.json @@ -78,3 +78,4 @@ }, "homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/error-reporting" } + diff --git a/handwritten/firestore/package.json b/handwritten/firestore/package.json index 0dee01e6dcfc..2242c9cfd93f 100644 --- a/handwritten/firestore/package.json +++ b/handwritten/firestore/package.json @@ -144,3 +144,4 @@ }, "homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/firestore" } + diff --git a/handwritten/google-cloud-dns/package.json b/handwritten/google-cloud-dns/package.json index ae52e9edfff2..6c9ade833241 100644 --- a/handwritten/google-cloud-dns/package.json +++ b/handwritten/google-cloud-dns/package.json @@ -76,3 +76,4 @@ }, "homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/google-cloud-dns" } + diff --git a/handwritten/logging-bunyan/package.json b/handwritten/logging-bunyan/package.json index 06a9a7d6b4c1..59d7ee4b8bad 100644 --- a/handwritten/logging-bunyan/package.json +++ b/handwritten/logging-bunyan/package.json @@ -87,3 +87,4 @@ }, "homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/logging-bunyan" } + diff --git a/handwritten/logging-winston/package.json b/handwritten/logging-winston/package.json index 6d86bcbf0f6d..2f7b1f819489 100644 --- a/handwritten/logging-winston/package.json +++ b/handwritten/logging-winston/package.json @@ -83,3 +83,4 @@ }, "homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/logging-winston" } + diff --git a/handwritten/logging/package.json b/handwritten/logging/package.json index cf7dcce0ef23..f45e12df0151 100644 --- a/handwritten/logging/package.json +++ b/handwritten/logging/package.json @@ -108,3 +108,4 @@ }, "homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/logging" } + diff --git a/handwritten/pubsub/package.json b/handwritten/pubsub/package.json index e43dd2101941..0dcfccd16592 100644 --- a/handwritten/pubsub/package.json +++ b/handwritten/pubsub/package.json @@ -109,3 +109,4 @@ }, "homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/pubsub" } + diff --git a/handwritten/spanner-driver/package.json b/handwritten/spanner-driver/package.json index 5413cb7b74d2..feb27bc6bb22 100644 --- a/handwritten/spanner-driver/package.json +++ b/handwritten/spanner-driver/package.json @@ -60,3 +60,4 @@ "node": ">=18" } } + diff --git a/handwritten/spanner/package.json b/handwritten/spanner/package.json index 6b4117a8f474..2e0de5828c9a 100644 --- a/handwritten/spanner/package.json +++ b/handwritten/spanner/package.json @@ -151,3 +151,4 @@ }, "homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/spanner" } + diff --git a/handwritten/storage/package.json b/handwritten/storage/package.json index ed2c26993026..e39bf9ed3bf1 100644 --- a/handwritten/storage/package.json +++ b/handwritten/storage/package.json @@ -130,3 +130,4 @@ }, "homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/storage" } + From 665a192b957c40eeb2eae0b1794a0fa1acb341a7 Mon Sep 17 00:00:00 2001 From: Brent Shaffer Date: Wed, 29 Jul 2026 21:03:31 +0000 Subject: [PATCH 2/3] trigger conformance/generator/mandatory-conformance tests --- .github/workflows/conformance-test.yaml | 8 ++++---- .github/workflows/conformance.yaml | 8 ++++---- .github/workflows/generator-tests.yaml | 12 ++++++------ .github/workflows/mandatory-conformance.yaml | 8 ++++---- 4 files changed, 18 insertions(+), 18 deletions(-) diff --git a/.github/workflows/conformance-test.yaml b/.github/workflows/conformance-test.yaml index 13eb09ab8981..eae3847ebe95 100644 --- a/.github/workflows/conformance-test.yaml +++ b/.github/workflows/conformance-test.yaml @@ -5,11 +5,11 @@ on: push: branches: - main - paths: - - 'handwritten/storage/**' + # paths: + # - 'handwritten/storage/**' pull_request: - paths: - - 'handwritten/storage/**' + # paths: + # - 'handwritten/storage/**' name: conformance jobs: conformance-test: diff --git a/.github/workflows/conformance.yaml b/.github/workflows/conformance.yaml index c35f95e5afb3..0db46be658a3 100644 --- a/.github/workflows/conformance.yaml +++ b/.github/workflows/conformance.yaml @@ -20,11 +20,11 @@ on: push: branches: - main - paths: - - 'handwritten/bigtable/**' + # paths: + # - 'handwritten/bigtable/**' pull_request: - paths: - - 'handwritten/bigtable/**' + # paths: + # - 'handwritten/bigtable/**' name: conformance jobs: conformance: diff --git a/.github/workflows/generator-tests.yaml b/.github/workflows/generator-tests.yaml index 1702f17e7a8d..639307cae7fa 100644 --- a/.github/workflows/generator-tests.yaml +++ b/.github/workflows/generator-tests.yaml @@ -6,13 +6,13 @@ on: push: branches: - main - paths: - - 'core/generator/**' - - '.github/workflows/generator-tests.yaml' + # paths: + # - 'core/generator/**' + # - '.github/workflows/generator-tests.yaml' pull_request: - paths: - - 'core/generator/**' - - '.github/workflows/generator-tests.yaml' + # paths: + # - 'core/generator/**' + # - '.github/workflows/generator-tests.yaml' workflow_dispatch: jobs: diff --git a/.github/workflows/mandatory-conformance.yaml b/.github/workflows/mandatory-conformance.yaml index e5ef9372c656..abb86bc5259a 100644 --- a/.github/workflows/mandatory-conformance.yaml +++ b/.github/workflows/mandatory-conformance.yaml @@ -20,11 +20,11 @@ on: push: branches: - main - paths: - - 'handwritten/bigtable/**' + # paths: + # - 'handwritten/bigtable/**' pull_request: - paths: - - 'handwritten/bigtable/**' + # paths: + # - 'handwritten/bigtable/**' name: mandatory-conformance jobs: mandatory-conformance: From 96cc913847328fc3b541a56abd372c70030c6642 Mon Sep 17 00:00:00 2001 From: Brent Shaffer Date: Thu, 30 Jul 2026 13:46:12 +0000 Subject: [PATCH 3/3] fix bigtable-system-tests --- .../src/client-side-metrics/exporter.ts | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/handwritten/bigtable/src/client-side-metrics/exporter.ts b/handwritten/bigtable/src/client-side-metrics/exporter.ts index fa4fd3a900a8..df5e0bb209e6 100644 --- a/handwritten/bigtable/src/client-side-metrics/exporter.ts +++ b/handwritten/bigtable/src/client-side-metrics/exporter.ts @@ -52,14 +52,24 @@ function getInterval( | DataPoint | DataPoint, ) { + let endSec = dataPoint.endTime[0]; + let endNanos = dataPoint.endTime[1]; + const startSec = dataPoint.startTime[0]; + const startNanos = dataPoint.startTime[1]; + + if (startSec > endSec || (startSec === endSec && startNanos > endNanos)) { + endSec = startSec; + endNanos = startNanos; + } + return { endTime: { - seconds: dataPoint.endTime[0], - nanos: dataPoint.endTime[1], + seconds: endSec, + nanos: endNanos, }, startTime: { - seconds: dataPoint.startTime[0], - nanos: dataPoint.startTime[1], + seconds: startSec, + nanos: startNanos, }, }; }