diff --git a/handwritten/storage/system-test/storage.ts b/handwritten/storage/system-test/storage.ts index cf8074d52671..012189084f59 100644 --- a/handwritten/storage/system-test/storage.ts +++ b/handwritten/storage/system-test/storage.ts @@ -235,12 +235,20 @@ describe('storage', function () { ); }); - it('should get access controls', async () => { + /** + * TODO: Re-enable once the test environment is configured without uniform bucket-level access. + * Currently disabled because uniform bucket-level access disables ACLs. + */ + it.skip('should get access controls', async () => { const accessControls = await bucket.acl.get(); assert(Array.isArray(accessControls)); }); - it('should add entity to default access controls', async () => { + /** + * TODO: Re-enable once the test environment is configured without uniform bucket-level access. + * Currently disabled because uniform bucket-level access disables ACLs. + */ + it.skip('should add entity to default access controls', async () => { const [accessControl] = await bucket.acl.default.add({ entity: USER_ACCOUNT, role: storage.acl.OWNER_ROLE, @@ -255,12 +263,20 @@ describe('storage', function () { await bucket.acl.default.delete({entity: USER_ACCOUNT}); }); - it('should get default access controls', async () => { + /** + * TODO: Re-enable once the test environment is configured without uniform bucket-level access. + * Currently disabled because uniform bucket-level access disables ACLs. + */ + it.skip('should get default access controls', async () => { const accessControls = await bucket.acl.default.get(); assert(Array.isArray(accessControls)); }); - it('should grant an account access', async () => { + /** + * TODO: Re-enable once the test environment is configured without uniform bucket-level access. + * Currently disabled because uniform bucket-level access disables ACLs. + */ + it.skip('should grant an account access', async () => { const [accessControl] = await bucket.acl.add({ entity: USER_ACCOUNT, role: storage.acl.OWNER_ROLE, @@ -275,7 +291,11 @@ describe('storage', function () { await bucket.acl.delete(opts); }); - it('should update an account', async () => { + /** + * TODO: Re-enable once the test environment is configured without uniform bucket-level access. + * Currently disabled because uniform bucket-level access disables ACLs. + */ + it.skip('should update an account', async () => { const [accessControl] = await bucket.acl.add({ entity: USER_ACCOUNT, role: storage.acl.OWNER_ROLE, @@ -350,7 +370,11 @@ describe('storage', function () { } }); - it('should make files private', async () => { + /** + * TODO: Re-enable once the test environment is configured without uniform bucket-level access. + * Currently disabled because uniform bucket-level access disables ACLs. + */ + it.skip('should make files private', async () => { await Promise.all( ['a', 'b', 'c'].map(text => createFileWithContentPromise(text)), ); @@ -381,7 +405,11 @@ describe('storage', function () { await file.delete(); }); - it('should get access controls', async () => { + /** + * TODO: Re-enable once the test environment is configured without uniform bucket-level access. + * Currently disabled because uniform bucket-level access disables ACLs. + */ + it.skip('should get access controls', async () => { const [accessControls] = await file.acl.get(); assert(Array.isArray(accessControls)); }); @@ -391,7 +419,11 @@ describe('storage', function () { assert.strictEqual(typeof (file as any).default, 'undefined'); }); - it('should grant an account access', async () => { + /** + * TODO: Re-enable once the test environment is configured without uniform bucket-level access. + * Currently disabled because uniform bucket-level access disables ACLs. + */ + it.skip('should grant an account access', async () => { const [accessControl] = await file.acl.add({ entity: USER_ACCOUNT, role: storage.acl.OWNER_ROLE, @@ -405,7 +437,11 @@ describe('storage', function () { await file.acl.delete({entity: USER_ACCOUNT}); }); - it('should update an account', async () => { + /** + * TODO: Re-enable once the test environment is configured without uniform bucket-level access. + * Currently disabled because uniform bucket-level access disables ACLs. + */ + it.skip('should update an account', async () => { const [accessControl] = await file.acl.add({ entity: USER_ACCOUNT, role: storage.acl.OWNER_ROLE, @@ -434,7 +470,11 @@ describe('storage', function () { await file.acl.delete({entity: 'allUsers'}); }); - it('should make a file private', async () => { + /** + * TODO: Re-enable once the test environment is configured without uniform bucket-level access. + * Currently disabled because uniform bucket-level access disables ACLs. + */ + it.skip('should make a file private', async () => { const validateMakeFilePrivateRejects = (err: ApiError) => { assert.strictEqual(err.code, 404); assert.strictEqual(err!.errors![0].reason, 'notFound'); @@ -507,7 +547,11 @@ describe('storage', function () { }); }); - it('should make a file private from a resumable upload', async () => { + /** + * TODO: Re-enable once the test environment is configured without uniform bucket-level access. + * Currently disabled because uniform bucket-level access disables ACLs. + */ + it.skip('should make a file private from a resumable upload', async () => { const validateMakeFilePrivateRejects = (err: ApiError) => { assert.strictEqual((err as ApiError)!.code, 404); assert.strictEqual((err as ApiError).errors![0].reason, 'notFound'); @@ -1159,7 +1203,11 @@ describe('storage', function () { describe('preserves bucket/file ACL over uniform bucket-level access on/off', () => { beforeEach(createBucket); - it('should preserve default bucket ACL', async () => { + /** + * TODO: Re-enable once the test environment is configured without uniform bucket-level access. + * Currently disabled because uniform bucket-level access disables ACLs. + */ + it.skip('should preserve default bucket ACL', async () => { await bucket.acl.default.update(customAcl); const [aclBefore] = await bucket.acl.default.get(); @@ -1178,7 +1226,11 @@ describe('storage', function () { } }).timeout(UNIFORM_ACCESS_TIMEOUT); - it('should preserve file ACL', async () => { + /** + * TODO: Re-enable once the test environment is configured without uniform bucket-level access. + * Currently disabled because uniform bucket-level access disables ACLs. + */ + it.skip('should preserve file ACL', async () => { const file = bucket.file(`file-${crypto.randomUUID()}`); await file.save('data', {resumable: false}); @@ -3140,9 +3192,8 @@ describe('storage', function () { }); /** - * TODO: Re-enable once the test environment allows public IAM roles. - * Currently disabled to avoid 403 errors when adding 'allUsers' or - * 'allAuthenticatedUsers' permissions. + * TODO: Re-enable once the test environment is configured without uniform bucket-level access. + * Currently disabled because uniform bucket-level access disables ACLs. */ it.skip('should respect predefined Acl at file#copy', async () => { const opts = {destination: 'CloudLogo'};