From c5e090d7a10acd1558629768af28e8f4ee43f1ca Mon Sep 17 00:00:00 2001 From: bajajnehaa Date: Fri, 6 Mar 2026 07:23:45 +0000 Subject: [PATCH 1/4] chore(cpp): Update update cache sample and add ttl option --- .../v2/samples/storage_control_anywhere_cache_samples.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/google/cloud/storagecontrol/v2/samples/storage_control_anywhere_cache_samples.cc b/google/cloud/storagecontrol/v2/samples/storage_control_anywhere_cache_samples.cc index 62f2f8b52ec08..c43a8a4f3618c 100644 --- a/google/cloud/storagecontrol/v2/samples/storage_control_anywhere_cache_samples.cc +++ b/google/cloud/storagecontrol/v2/samples/storage_control_anywhere_cache_samples.cc @@ -90,9 +90,9 @@ void UpdateAnywhereCache( std::string const& admission_policy) { google::storage::control::v2::AnywhereCache cache; google::protobuf::FieldMask field_mask; - field_mask.add_paths("admission_policy"); + field_mask.add_paths("ttl"); cache.set_name(cache_name); - cache.set_admission_policy(admission_policy); + cache->mutable_ttl()->set_seconds(86400); // Start an update operation and block until it completes. Real applications // may want to setup a callback, wait on a coroutine, or poll until it // completes. From 0d36482e2b109a64fda5781f02a99f1a8b4ab247 Mon Sep 17 00:00:00 2001 From: bajajnehaa Date: Fri, 6 Mar 2026 10:26:50 +0000 Subject: [PATCH 2/4] fix ci failures --- .../v2/samples/storage_control_anywhere_cache_samples.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/google/cloud/storagecontrol/v2/samples/storage_control_anywhere_cache_samples.cc b/google/cloud/storagecontrol/v2/samples/storage_control_anywhere_cache_samples.cc index c43a8a4f3618c..59d13bcbb3045 100644 --- a/google/cloud/storagecontrol/v2/samples/storage_control_anywhere_cache_samples.cc +++ b/google/cloud/storagecontrol/v2/samples/storage_control_anywhere_cache_samples.cc @@ -92,7 +92,7 @@ void UpdateAnywhereCache( google::protobuf::FieldMask field_mask; field_mask.add_paths("ttl"); cache.set_name(cache_name); - cache->mutable_ttl()->set_seconds(86400); + cache.mutable_ttl()->set_seconds(86400); // Start an update operation and block until it completes. Real applications // may want to setup a callback, wait on a coroutine, or poll until it // completes. From d794091e7a2a220ee9eb69c9c22e2f1fb2a19020 Mon Sep 17 00:00:00 2001 From: bajajnehaa Date: Fri, 6 Mar 2026 11:28:33 +0000 Subject: [PATCH 3/4] fix ci failures --- .../v2/samples/storage_control_anywhere_cache_samples.cc | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/google/cloud/storagecontrol/v2/samples/storage_control_anywhere_cache_samples.cc b/google/cloud/storagecontrol/v2/samples/storage_control_anywhere_cache_samples.cc index 59d13bcbb3045..271ab5333030c 100644 --- a/google/cloud/storagecontrol/v2/samples/storage_control_anywhere_cache_samples.cc +++ b/google/cloud/storagecontrol/v2/samples/storage_control_anywhere_cache_samples.cc @@ -86,8 +86,8 @@ void UpdateAnywhereCache( std::vector const& argv) { // [START storage_control_update_anywhere_cache] namespace storagecontrol = google::cloud::storagecontrol_v2; - [](storagecontrol::StorageControlClient client, std::string const& cache_name, - std::string const& admission_policy) { + [](storagecontrol::StorageControlClient client, + std::string const& cache_name) { google::storage::control::v2::AnywhereCache cache; google::protobuf::FieldMask field_mask; field_mask.add_paths("ttl"); @@ -221,8 +221,7 @@ int main(int argc, char* argv[]) { // NOLINT(bugprone-exception-escape) CreateAnywhereCache), make_entry("get-anywhere-cache", {"cache-name"}, GetAnywhereCache), make_entry("list-anywhere-caches", {"bucket-name"}, ListAnywhereCaches), - make_entry("update-anywhere-cache", {"cache-name", "admission-policy"}, - UpdateAnywhereCache), + make_entry("update-anywhere-cache", {"cache-name"}, UpdateAnywhereCache), make_entry("pause-anywhere-cache", {"cache-name"}, PauseAnywhereCache), make_entry("resume-anywhere-cache", {"cache-name"}, ResumeAnywhereCache), make_entry("disable-anywhere-cache", {"cache-name"}, From 11d9ab9ec93382dca40a2d90c51fa3134270acb5 Mon Sep 17 00:00:00 2001 From: bajajnehaa Date: Fri, 6 Mar 2026 11:57:11 +0000 Subject: [PATCH 4/4] fix ci failures --- .../v2/samples/storage_control_anywhere_cache_samples.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/google/cloud/storagecontrol/v2/samples/storage_control_anywhere_cache_samples.cc b/google/cloud/storagecontrol/v2/samples/storage_control_anywhere_cache_samples.cc index 271ab5333030c..6abcd8c1cee81 100644 --- a/google/cloud/storagecontrol/v2/samples/storage_control_anywhere_cache_samples.cc +++ b/google/cloud/storagecontrol/v2/samples/storage_control_anywhere_cache_samples.cc @@ -101,7 +101,7 @@ void UpdateAnywhereCache( std::cout << "Updated anywhere cache: " << anywhere_cache->name() << "\n"; } // [END storage_control_update_anywhere_cache] - (std::move(client), argv.at(0), argv.at(1)); + (std::move(client), argv.at(0)); } void PauseAnywhereCache(