From 60db5859fd99d96ae3eb7b2689769be700f8726a Mon Sep 17 00:00:00 2001 From: Josh Radcliff Date: Mon, 18 Aug 2025 15:16:47 -0400 Subject: [PATCH 1/6] test: add Gradle workflow to test PRs Change-Id: I483b15cc0297143e5d35ddfe9d4efab32f7afd99 --- .github/workflows/presubmit.yaml | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 .github/workflows/presubmit.yaml diff --git a/.github/workflows/presubmit.yaml b/.github/workflows/presubmit.yaml new file mode 100644 index 0000000..421e3c5 --- /dev/null +++ b/.github/workflows/presubmit.yaml @@ -0,0 +1,25 @@ +# Gives read-only access +permissions: read-all +name: Presubmit +on: + pull_request: + branches: + - main +jobs: + build: + runs-on: ubuntu-latest + # TODO(jradcliff): Determine how to prevent this from running unless the PR + # label was added by a user in CODEOWNERS. + if: contains(github.event.pull_request.labels.*.name, 'run-presubmit') + steps: + - name: Checkout sources + uses: actions/checkout@v4 + - name: Set up Java + uses: actions/setup-java@v4 + with: + java-version: '11' + distribution: 'temurin' + - name: Setup Gradle + uses: gradle/actions/setup-gradle@v4 + - name: Build with Gradle + run: ./gradlew build From d4ad748a18eb147c6b24930deeb10a9932da920e Mon Sep 17 00:00:00 2001 From: Josh Radcliff Date: Thu, 23 Oct 2025 11:50:13 -0400 Subject: [PATCH 2/6] add formatting check --- .github/workflows/presubmit.yaml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/presubmit.yaml b/.github/workflows/presubmit.yaml index 421e3c5..449f5b9 100644 --- a/.github/workflows/presubmit.yaml +++ b/.github/workflows/presubmit.yaml @@ -8,9 +8,6 @@ on: jobs: build: runs-on: ubuntu-latest - # TODO(jradcliff): Determine how to prevent this from running unless the PR - # label was added by a user in CODEOWNERS. - if: contains(github.event.pull_request.labels.*.name, 'run-presubmit') steps: - name: Checkout sources uses: actions/checkout@v4 @@ -19,6 +16,8 @@ jobs: with: java-version: '11' distribution: 'temurin' + - name: Run Java Lint Check (including google-java-format) + uses: abcxyz/actions/.github/actions/lint-java@main - name: Setup Gradle uses: gradle/actions/setup-gradle@v4 - name: Build with Gradle From 3dd5c91916d53d72833e1aac5456a33d7cc4aff8 Mon Sep 17 00:00:00 2001 From: Josh Radcliff Date: Thu, 23 Oct 2025 12:00:47 -0400 Subject: [PATCH 3/6] set directory and add separate util and samples steps --- .github/workflows/presubmit.yaml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/presubmit.yaml b/.github/workflows/presubmit.yaml index 449f5b9..186f345 100644 --- a/.github/workflows/presubmit.yaml +++ b/.github/workflows/presubmit.yaml @@ -16,8 +16,14 @@ jobs: with: java-version: '11' distribution: 'temurin' - - name: Run Java Lint Check (including google-java-format) + - name: Run Java Lint Check on utilities uses: abcxyz/actions/.github/actions/lint-java@main + with: + directory: 'data-manager-util/src' + - name: Run Java Lint Check on samples + uses: abcxyz/actions/.github/actions/lint-java@main + with: + directory: 'data-manager-samples/src' - name: Setup Gradle uses: gradle/actions/setup-gradle@v4 - name: Build with Gradle From 6baa3a2184a24505ec27ac86d1c186e036af0112 Mon Sep 17 00:00:00 2001 From: Josh Radcliff Date: Thu, 23 Oct 2025 12:05:05 -0400 Subject: [PATCH 4/6] try reordering steps --- .github/workflows/presubmit.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/presubmit.yaml b/.github/workflows/presubmit.yaml index 186f345..adb7530 100644 --- a/.github/workflows/presubmit.yaml +++ b/.github/workflows/presubmit.yaml @@ -16,15 +16,17 @@ jobs: with: java-version: '11' distribution: 'temurin' + - name: Setup Gradle + uses: gradle/actions/setup-gradle@v4 - name: Run Java Lint Check on utilities uses: abcxyz/actions/.github/actions/lint-java@main with: directory: 'data-manager-util/src' + graalvm_java_version: '11' - name: Run Java Lint Check on samples uses: abcxyz/actions/.github/actions/lint-java@main with: directory: 'data-manager-samples/src' - - name: Setup Gradle - uses: gradle/actions/setup-gradle@v4 + graalvm_java_version: '11' - name: Build with Gradle run: ./gradlew build From c80e6acf3203e771f3471a71c369d3e989398e6c Mon Sep 17 00:00:00 2001 From: Josh Radcliff Date: Thu, 23 Oct 2025 12:07:48 -0400 Subject: [PATCH 5/6] remove graalvm version --- .github/workflows/presubmit.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/presubmit.yaml b/.github/workflows/presubmit.yaml index adb7530..edb922b 100644 --- a/.github/workflows/presubmit.yaml +++ b/.github/workflows/presubmit.yaml @@ -22,11 +22,9 @@ jobs: uses: abcxyz/actions/.github/actions/lint-java@main with: directory: 'data-manager-util/src' - graalvm_java_version: '11' - name: Run Java Lint Check on samples uses: abcxyz/actions/.github/actions/lint-java@main with: directory: 'data-manager-samples/src' - graalvm_java_version: '11' - name: Build with Gradle run: ./gradlew build From a43c69bc77aafb66ac582965fdd8930ea447e5ba Mon Sep 17 00:00:00 2001 From: Josh Radcliff Date: Thu, 23 Oct 2025 13:43:07 -0400 Subject: [PATCH 6/6] remove lint step for now --- .github/workflows/presubmit.yaml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/.github/workflows/presubmit.yaml b/.github/workflows/presubmit.yaml index edb922b..8115684 100644 --- a/.github/workflows/presubmit.yaml +++ b/.github/workflows/presubmit.yaml @@ -18,13 +18,6 @@ jobs: distribution: 'temurin' - name: Setup Gradle uses: gradle/actions/setup-gradle@v4 - - name: Run Java Lint Check on utilities - uses: abcxyz/actions/.github/actions/lint-java@main - with: - directory: 'data-manager-util/src' - - name: Run Java Lint Check on samples - uses: abcxyz/actions/.github/actions/lint-java@main - with: - directory: 'data-manager-samples/src' + # TODO(jradcliff): Add a lint step. Currently blocked by https://github.com/abcxyz/actions/issues/107. - name: Build with Gradle run: ./gradlew build