Skip to content

Task completion with the fish shell raise a warning when distro use the go-task name instead of task #2727

@rlapray

Description

@rlapray

Description

Hello,

The task completion with the shell fish raised a warning on manjaro (and probably on archlinux too) because these systems use the name "go-task" instead of"task".

go-task fish: Unknown command: taskcom
in command substitution
        called on line 19 of file /usr/share/fish/vendor_completions.d/go-task.fish
in function '__go_task_get_experiments'
        called on line 27 of file /usr/share/fish/vendor_completions.d/go-task.fish
in function '__go_task_is_experiment_enabled' with arguments 'REMOTE_TASKFILES'
in command substitution
/usr/share/fish/vendor_completions.d/go-task.fish (line 19): Unknown command
    set -g __go_task_experiments_cache (task --experiments 2>/dev/null)
                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
in function '__go_task_get_experiments'
        called on line 27 of file /usr/share/fish/vendor_completions.d/go-task.fish
in function '__go_task_is_experiment_enabled' with arguments 'REMOTE_TASKFILES'
in command substitution

The completion still works afterwards, but the warning remains.

I've started looking at the code and i saw this :

# Refresh cache
set -g __task_experiments_cache (task --experiments 2>/dev/null)

If i understand this file correctly it seems like instead of using task directy the code should use $GO_TASK_PROGNAME .

Would you accept a PR for this ?

Thank you for your time !

Version

3.48.0

Operating system

Linux 6.18.12-1-MANJARO

Experiments Enabled

No response

Example Taskfile

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: completionsChanges related to shell completions and scripts.

    Type

    No fields configured for bug.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions