From 9fd919215a8334905496cc83cda06ba81899eed2 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu, 23 Jul 2026 13:18:36 +0000 Subject: [PATCH] test: fix vacuous assertions in src/execute.rs Upgrade 5 bare is_err() assertions to check the error message, following the pattern established in previous test-reducer runs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- src/execute.rs | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/execute.rs b/src/execute.rs index 11f9dde4..0e033022 100644 --- a/src/execute.rs +++ b/src/execute.rs @@ -1012,7 +1012,8 @@ mod tests { let ctx = ExecutionContext::default(); let result = execute_safe_output(&entry, &ctx).await; - assert!(result.is_err()); + let err = result.unwrap_err().to_string(); + assert!(err.contains("Failed to parse create-work-item"), "err: {err}"); } #[tokio::test] @@ -1032,7 +1033,8 @@ mod tests { let ctx = ExecutionContext::default(); let result = execute_safe_output(&entry, &ctx).await; - assert!(result.is_err()); + let err = result.unwrap_err().to_string(); + assert!(err.contains("Failed to parse update-wiki-page"), "err: {err}"); } #[tokio::test] @@ -1078,7 +1080,8 @@ mod tests { let ctx = ExecutionContext::default(); let result = execute_safe_output(&entry, &ctx).await; - assert!(result.is_err()); + let err = result.unwrap_err().to_string(); + assert!(err.contains("Failed to parse create-wiki-page"), "err: {err}"); } #[tokio::test] @@ -1088,7 +1091,8 @@ mod tests { let ctx = ExecutionContext::default(); let result = execute_safe_output(&entry, &ctx).await; - assert!(result.is_err()); + let err = result.unwrap_err().to_string(); + assert!(err.contains("Failed to parse upload-pipeline-artifact"), "err: {err}"); } #[tokio::test] @@ -1134,7 +1138,8 @@ mod tests { let ctx = ExecutionContext::default(); let result = execute_safe_output(&entry, &ctx).await; - assert!(result.is_err()); + let err = result.unwrap_err().to_string(); + assert!(err.contains("Failed to parse comment-on-work-item"), "err: {err}"); } #[tokio::test] @@ -1144,7 +1149,8 @@ mod tests { let ctx = ExecutionContext::default(); let result = execute_safe_output(&entry, &ctx).await; - assert!(result.is_err()); + let err = result.unwrap_err().to_string(); + assert!(err.contains("Failed to parse upload-workitem-attachment"), "err: {err}"); } #[tokio::test]