From 4204a90b50dd2cd6aca88101d05297d5c3561be3 Mon Sep 17 00:00:00 2001
From: "github-actions[bot]"
 <41898282+github-actions[bot]@users.noreply.github.com>
Date: Thu, 23 Jul 2026 01:15:08 +0000
Subject: [PATCH] test: fix vacuous assertions in link_work_items and
 missing_tool

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 src/safe_outputs/link_work_items.rs | 28 ++++++++++++++++++++--------
 src/safe_outputs/missing_tool.rs    |  8 ++++++--
 2 files changed, 26 insertions(+), 10 deletions(-)

diff --git a/src/safe_outputs/link_work_items.rs b/src/safe_outputs/link_work_items.rs
index d9e2bae9..83acbf7f 100644
--- a/src/safe_outputs/link_work_items.rs
+++ b/src/safe_outputs/link_work_items.rs
@@ -340,8 +340,11 @@ mod tests {
             link_type: "related".to_string(),
             comment: None,
         };
-        let result: Result<LinkWorkItemsResult, _> = params.try_into();
-        assert!(result.is_err());
+        let err = LinkWorkItemsResult::try_from(params).unwrap_err();
+        assert!(
+            err.to_string().contains("source_id must be positive"),
+            "expected error about source_id, got: {err}"
+        );
     }
 
     #[test]
@@ -352,8 +355,11 @@ mod tests {
             link_type: "related".to_string(),
             comment: None,
         };
-        let result: Result<LinkWorkItemsResult, _> = params.try_into();
-        assert!(result.is_err());
+        let err = LinkWorkItemsResult::try_from(params).unwrap_err();
+        assert!(
+            err.to_string().contains("target_id must be positive"),
+            "expected error about target_id, got: {err}"
+        );
     }
 
     #[test]
@@ -364,8 +370,11 @@ mod tests {
             link_type: "related".to_string(),
             comment: None,
         };
-        let result: Result<LinkWorkItemsResult, _> = params.try_into();
-        assert!(result.is_err());
+        let err = LinkWorkItemsResult::try_from(params).unwrap_err();
+        assert!(
+            err.to_string().contains("source_id and target_id must be different"),
+            "expected error about same ids, got: {err}"
+        );
     }
 
     #[test]
@@ -376,8 +385,11 @@ mod tests {
             link_type: "unknown".to_string(),
             comment: None,
         };
-        let result: Result<LinkWorkItemsResult, _> = params.try_into();
-        assert!(result.is_err());
+        let err = LinkWorkItemsResult::try_from(params).unwrap_err();
+        assert!(
+            err.to_string().contains("invalid link_type"),
+            "expected error about invalid link_type, got: {err}"
+        );
     }
 
     #[test]
diff --git a/src/safe_outputs/missing_tool.rs b/src/safe_outputs/missing_tool.rs
index 1a1d0eb1..d0550860 100644
--- a/src/safe_outputs/missing_tool.rs
+++ b/src/safe_outputs/missing_tool.rs
@@ -93,8 +93,12 @@ mod tests {
     #[test]
     fn test_params_requires_tool_name() {
         let json = r#"{"context": "why"}"#;
-        let result: Result<MissingToolParams, _> = serde_json::from_str(json);
-        assert!(result.is_err());
+        let result = serde_json::from_str::<MissingToolParams>(json);
+        let err = result.map(|_| ()).unwrap_err().to_string();
+        assert!(
+            err.contains("tool_name"),
+            "expected error about missing tool_name field, got: {err}"
+        );
     }
 
     #[tokio::test]