diff --git a/src/safe_outputs/link_work_items.rs b/src/safe_outputs/link_work_items.rs index d9e2bae9..83acbf7f 100644 --- a/src/safe_outputs/link_work_items.rs +++ b/src/safe_outputs/link_work_items.rs @@ -340,8 +340,11 @@ mod tests { link_type: "related".to_string(), comment: None, }; - let result: Result = params.try_into(); - assert!(result.is_err()); + let err = LinkWorkItemsResult::try_from(params).unwrap_err(); + assert!( + err.to_string().contains("source_id must be positive"), + "expected error about source_id, got: {err}" + ); } #[test] @@ -352,8 +355,11 @@ mod tests { link_type: "related".to_string(), comment: None, }; - let result: Result = params.try_into(); - assert!(result.is_err()); + let err = LinkWorkItemsResult::try_from(params).unwrap_err(); + assert!( + err.to_string().contains("target_id must be positive"), + "expected error about target_id, got: {err}" + ); } #[test] @@ -364,8 +370,11 @@ mod tests { link_type: "related".to_string(), comment: None, }; - let result: Result = params.try_into(); - assert!(result.is_err()); + let err = LinkWorkItemsResult::try_from(params).unwrap_err(); + assert!( + err.to_string().contains("source_id and target_id must be different"), + "expected error about same ids, got: {err}" + ); } #[test] @@ -376,8 +385,11 @@ mod tests { link_type: "unknown".to_string(), comment: None, }; - let result: Result = params.try_into(); - assert!(result.is_err()); + let err = LinkWorkItemsResult::try_from(params).unwrap_err(); + assert!( + err.to_string().contains("invalid link_type"), + "expected error about invalid link_type, got: {err}" + ); } #[test] diff --git a/src/safe_outputs/missing_tool.rs b/src/safe_outputs/missing_tool.rs index 1a1d0eb1..d0550860 100644 --- a/src/safe_outputs/missing_tool.rs +++ b/src/safe_outputs/missing_tool.rs @@ -93,8 +93,12 @@ mod tests { #[test] fn test_params_requires_tool_name() { let json = r#"{"context": "why"}"#; - let result: Result = serde_json::from_str(json); - assert!(result.is_err()); + let result = serde_json::from_str::(json); + let err = result.map(|_| ()).unwrap_err().to_string(); + assert!( + err.contains("tool_name"), + "expected error about missing tool_name field, got: {err}" + ); } #[tokio::test]