Skip to content

Commit 410ecdd

Browse files
Fix repository resource tests to work with current API
Co-authored-by: SamMorrowDrums <4811358+SamMorrowDrums@users.noreply.github.com>
1 parent afe274a commit 410ecdd

File tree

1 file changed

+17
-14
lines changed

1 file changed

+17
-14
lines changed

pkg/github/repository_resource_test.go

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import (
88
"testing"
99

1010
"github.com/github/github-mcp-server/pkg/raw"
11+
"github.com/github/github-mcp-server/pkg/translations"
1112
"github.com/google/go-github/v79/github"
1213
"github.com/modelcontextprotocol/go-sdk/mcp"
1314
"github.com/stretchr/testify/require"
@@ -292,7 +293,13 @@ func Test_repositoryResourceContentsHandler_NetworkError(t *testing.T) {
292293
httpClient := &http.Client{Transport: &errorTransport{err: networkErr}}
293294
client := github.NewClient(httpClient)
294295
mockRawClient := raw.NewClient(client, base)
295-
handler := RepositoryResourceContentsHandler(stubGetClientFn(client), stubGetRawClientFn(mockRawClient), repositoryResourceContentURITemplate)
296+
297+
deps := BaseDeps{
298+
Client: client,
299+
RawClient: mockRawClient,
300+
}
301+
ctx := ContextWithDeps(context.Background(), deps)
302+
handler := RepositoryResourceContentsHandler(repositoryResourceContentURITemplate)
296303

297304
request := &mcp.ReadResourceRequest{
298305
Params: &mcp.ReadResourceParams{
@@ -301,31 +308,27 @@ func Test_repositoryResourceContentsHandler_NetworkError(t *testing.T) {
301308
}
302309

303310
// This should not panic, even though the HTTP client returns an error
304-
resp, err := handler(context.TODO(), request)
311+
resp, err := handler(ctx, request)
305312
require.Error(t, err)
306313
require.Nil(t, resp)
307314
require.ErrorContains(t, err, "failed to get raw content")
308315
}
309316

310317
func Test_GetRepositoryResourceContent(t *testing.T) {
311-
mockRawClient := raw.NewClient(github.NewClient(nil), &url.URL{})
312-
tmpl, _ := GetRepositoryResourceContent(nil, stubGetRawClientFn(mockRawClient), translations.NullTranslationHelper)
313-
require.Equal(t, "repo://{owner}/{repo}/contents{/path*}", tmpl.URITemplate)
318+
tmpl := GetRepositoryResourceContent(translations.NullTranslationHelper)
319+
require.Equal(t, "repo://{owner}/{repo}/contents{/path*}", tmpl.Template.URITemplate)
314320
}
315321

316322
func Test_GetRepositoryResourceBranchContent(t *testing.T) {
317-
mockRawClient := raw.NewClient(github.NewClient(nil), &url.URL{})
318-
tmpl, _ := GetRepositoryResourceBranchContent(nil, stubGetRawClientFn(mockRawClient), translations.NullTranslationHelper)
319-
require.Equal(t, "repo://{owner}/{repo}/refs/heads/{branch}/contents{/path*}", tmpl.URITemplate)
323+
tmpl := GetRepositoryResourceBranchContent(translations.NullTranslationHelper)
324+
require.Equal(t, "repo://{owner}/{repo}/refs/heads/{branch}/contents{/path*}", tmpl.Template.URITemplate)
320325
}
321326
func Test_GetRepositoryResourceCommitContent(t *testing.T) {
322-
mockRawClient := raw.NewClient(github.NewClient(nil), &url.URL{})
323-
tmpl, _ := GetRepositoryResourceCommitContent(nil, stubGetRawClientFn(mockRawClient), translations.NullTranslationHelper)
324-
require.Equal(t, "repo://{owner}/{repo}/sha/{sha}/contents{/path*}", tmpl.URITemplate)
327+
tmpl := GetRepositoryResourceCommitContent(translations.NullTranslationHelper)
328+
require.Equal(t, "repo://{owner}/{repo}/sha/{sha}/contents{/path*}", tmpl.Template.URITemplate)
325329
}
326330

327331
func Test_GetRepositoryResourceTagContent(t *testing.T) {
328-
mockRawClient := raw.NewClient(github.NewClient(nil), &url.URL{})
329-
tmpl, _ := GetRepositoryResourceTagContent(nil, stubGetRawClientFn(mockRawClient), translations.NullTranslationHelper)
330-
require.Equal(t, "repo://{owner}/{repo}/refs/tags/{tag}/contents{/path*}", tmpl.URITemplate)
332+
tmpl := GetRepositoryResourceTagContent(translations.NullTranslationHelper)
333+
require.Equal(t, "repo://{owner}/{repo}/refs/tags/{tag}/contents{/path*}", tmpl.Template.URITemplate)
331334
}

0 commit comments

Comments
 (0)