From 8ba56f82dca92f22c73e4726463ff800d48cafb3 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu, 29 Oct 2026 14:27:20 +0000 Subject: [PATCH] chore: remove dead function doctorAssignmentCredential Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- pkg/cli/doctor_assign_to_agent.go | 4 ---- pkg/cli/doctor_assign_to_agent_parsing_test.go | 2 +- pkg/cli/doctor_assign_to_agent_test.go | 4 ++-- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/pkg/cli/doctor_assign_to_agent.go b/pkg/cli/doctor_assign_to_agent.go index 97d7cf7b859..3b89a630646 100644 --- a/pkg/cli/doctor_assign_to_agent.go +++ b/pkg/cli/doctor_assign_to_agent.go @@ -312,10 +312,6 @@ func diagnoseDoctorAssignmentsWithEnvironment(ctx context.Context, repo, host st return checks } -func doctorAssignmentCredential(token string, secrets map[string]struct{}, lookupErr error) (string, string, string) { - return doctorAssignmentCredentialWithEnvironment(token, secrets, lookupErr, nil, nil) -} - func doctorAssignmentCredentialWithEnvironment(token string, secrets map[string]struct{}, lookupErr error, environmentSecrets map[string]struct{}, environmentErr error) (string, string, string) { names, ok := doctorAssignmentSecretNames(strings.TrimSpace(token)) if !ok { diff --git a/pkg/cli/doctor_assign_to_agent_parsing_test.go b/pkg/cli/doctor_assign_to_agent_parsing_test.go index 01f955bcce7..5c01102229e 100644 --- a/pkg/cli/doctor_assign_to_agent_parsing_test.go +++ b/pkg/cli/doctor_assign_to_agent_parsing_test.go @@ -72,7 +72,7 @@ func TestDoctorAssignmentCredentialFlattenedFallbacks(t *testing.T) { for _, tc := range tests { t.Run(tc.name, func(t *testing.T) { t.Parallel() - status, secret, _ := doctorAssignmentCredential(tc.token, tc.secrets, tc.lookupErr) + status, secret, _ := doctorAssignmentCredentialWithEnvironment(tc.token, tc.secrets, tc.lookupErr, nil, nil) assert.Equal(t, tc.status, status) assert.Equal(t, tc.secret, secret) }) diff --git a/pkg/cli/doctor_assign_to_agent_test.go b/pkg/cli/doctor_assign_to_agent_test.go index 9ab37881609..17982fd87a2 100644 --- a/pkg/cli/doctor_assign_to_agent_test.go +++ b/pkg/cli/doctor_assign_to_agent_test.go @@ -50,7 +50,7 @@ func TestDoctorAssignmentCredential(t *testing.T) { for _, tc := range tests { t.Run(tc.name, func(t *testing.T) { t.Parallel() - status, secret, message := doctorAssignmentCredential(tc.token, tc.secrets, tc.lookupErr) + status, secret, message := doctorAssignmentCredentialWithEnvironment(tc.token, tc.secrets, tc.lookupErr, nil, nil) assert.Equal(t, tc.status, status) assert.Equal(t, tc.secret, secret) assert.NotContains(t, message, "never-echo-this-value") @@ -255,7 +255,7 @@ esac } } if tc.name == "personal repository missing secret" { - status, _, _ := doctorAssignmentCredential("${{ secrets.REPO_PAT }}", secrets, err) + status, _, _ := doctorAssignmentCredentialWithEnvironment("${{ secrets.REPO_PAT }}", secrets, err, nil, nil) assert.Equal(t, "missing", status) } if tc.name == "repository and inherited secrets" {