You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Location: README.md (Tracing section) and CONTRIBUTING.md (Advanced Flags section)
Problem: The --otlp-sample-rate flag is registered in internal/cmd/tracing.go but is not mentioned in README.md or CONTRIBUTING.md. Users configuring OpenTelemetry tracing have no way to discover this flag through the docs.
Actual Behavior: Flag exists and controls the OTLP trace sample rate. Default value comes from config.DefaultTracingSampleRate. Defaults from the OTEL_EXPORTER_OTLP_ENDPOINT env var when set.
Impact: Users enabling tracing won't know they can control the sample rate without reading the source code or running awmg --help.
Suggested Fix: Add --otlp-sample-rate to the Tracing section in README.md alongside the existing OTLP variable table, and optionally mention it in CONTRIBUTING.md Advanced Flags section.
All referenced example files exist (config.example.toml, config.example-payload-threshold.toml, example-http-config.json, example.env, agent-configs/codex.config.toml) ✅
Tested Commands
All make targets from CONTRIBUTING.md were verified against Makefile:
✅ make build — target exists, creates awmg binary as documented
✅ make test — alias for test-unit as documented
✅ make test-unit — runs ./internal/... as documented
✅ make test-integration — auto-builds binary if not present, as documented
✅ make test-all — depends on build target, rebuilds binary first as documented
✅ make test-rust — Rust guard tests with cargo, as documented
✅ make test-race — race detection tests, as documented
✅ make test-serena — Serena MCP tests, as documented
✅ make test-serena-gateway — Serena via gateway tests, as documented
✅ make test-container-proxy — container proxy tests, as documented
✅ make lint — go vet + gofmt + golangci-lint, as documented
✅ make coverage — unit tests with coverage report, as documented
✅ make install — installs golangci-lint v2.8.0 + Go deps, as documented
✅ make format — gofmt -w, as documented
✅ make clean — removes awmg, coverage.out, test-result-unit.json, as documented
✅ make agent-finished — format + build + lint + all tests, as documented
Recommendations
Nice to Have:
Add --otlp-sample-rate <float> to the Tracing section of README.md (after the OTLP env var table) with a brief description of its effect on trace sampling
Code References
Tracing flag registration: internal/cmd/tracing.go — registerTracingFlags()
Summary
Found 1 minor discrepancy between documentation and implementation during nightly reconciliation check.
Minor Issues 🔵
Small inconsistencies or missing details:
1.
--otlp-sample-rateflag is undocumentedLocation: README.md (Tracing section) and CONTRIBUTING.md (Advanced Flags section)
Problem: The
--otlp-sample-rateflag is registered ininternal/cmd/tracing.gobut is not mentioned in README.md or CONTRIBUTING.md. Users configuring OpenTelemetry tracing have no way to discover this flag through the docs.Actual Behavior: Flag exists and controls the OTLP trace sample rate. Default value comes from
config.DefaultTracingSampleRate. Defaults from theOTEL_EXPORTER_OTLP_ENDPOINTenv var when set.Impact: Users enabling tracing won't know they can control the sample rate without reading the source code or running
awmg --help.Suggested Fix: Add
--otlp-sample-rateto the Tracing section in README.md alongside the existing OTLP variable table, and optionally mention it in CONTRIBUTING.md Advanced Flags section.Code Reference:
internal/cmd/tracing.go—registerTracingFlags()function,flags.Float64Var(sampleRate, "otlp-sample-rate", ...)Documentation Completeness
Missing Documentation
--otlp-sample-rateflag: implemented ininternal/cmd/tracing.gobut not documented in README.md or CONTRIBUTING.mdAccurate Sections ✅
internal/config/config_core.goandconfig_stdin.go)commandfield — correctly documented (StdinServerConfigintentionally omitsCommand)go.mod✅awmg) — matches MakefileBINARY_NAME✅127.0.0.1:3000) — matchesDefaultListenIPv4+DefaultListenPortininternal/cmd/root.go✅/tmp/jq-payloads) — matchesDefaultPayloadDirininternal/config/config_core.go✅/tmp/gh-aw/mcp-logs) — matchesDefaultLogDir✅internal/envutil/github.go✅config.example.toml,config.example-payload-threshold.toml,example-http-config.json,example.env,agent-configs/codex.config.toml) ✅Tested Commands
All make targets from CONTRIBUTING.md were verified against Makefile:
make build— target exists, createsawmgbinary as documentedmake test— alias fortest-unitas documentedmake test-unit— runs./internal/...as documentedmake test-integration— auto-builds binary if not present, as documentedmake test-all— depends onbuildtarget, rebuilds binary first as documentedmake test-rust— Rust guard tests with cargo, as documentedmake test-race— race detection tests, as documentedmake test-serena— Serena MCP tests, as documentedmake test-serena-gateway— Serena via gateway tests, as documentedmake test-container-proxy— container proxy tests, as documentedmake lint— go vet + gofmt + golangci-lint, as documentedmake coverage— unit tests with coverage report, as documentedmake install— installs golangci-lint v2.8.0 + Go deps, as documentedmake format— gofmt -w, as documentedmake clean— removes awmg, coverage.out, test-result-unit.json, as documentedmake agent-finished— format + build + lint + all tests, as documentedRecommendations
Nice to Have:
--otlp-sample-rate <float>to the Tracing section of README.md (after the OTLP env var table) with a brief description of its effect on trace samplingCode References
internal/cmd/tracing.go—registerTracingFlags()internal/config/config_core.go,internal/config/config_stdin.gointernal/envutil/github.gointernal/cmd/flags_core.go,internal/cmd/flags_launch.goWarning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
proxy.golang.orgSee Network Configuration for more information.