Skip to content

Commit ff34138

Browse files
redsun82Copilot
andcommitted
Just: collect the one Starlark name buildifier knows and we did not
The list stands in for buildifier's own idea of what a Starlark file is, since that check is skipped for paths handed to it rather than walked to: whatever is listed here gets rewritten, and whatever is not is left for CI to rewrite instead. `*.star` was the one name it recognises that was missing, so a file added under it would have been formatted in CI and not by `just format`. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
1 parent bd84802 commit ff34138

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

misc/just/format.just

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,11 @@ _bazel_args := "-mode=fix -lint=fix"
2121
# at stake here, which is what the banner leaves out.
2222
_bazel_quiet := "--noshow_progress --ui_event_filters=,+error,+fail"
2323

24-
# Keep in step with the `buildifier` target's own exclusions, or `just format` rewrites
25-
# what pre-commit and CI deliberately leave alone. Patterns match the path as walked, so
26-
# one naming a directory has to cover both how it is reached and how it is walked.
27-
_bazel_names := "BUILD,WORKSPACE,*.bazel,*.bzl,*.sky"
24+
# Keep both in step with the `buildifier` target. The names are what it recognises walking a
25+
# workspace, a check it skips for paths handed to it, so anything extra here is rewritten
26+
# regardless. Exclusions match the path as walked, so one naming a directory has to cover
27+
# both how it is reached and how it is walked.
28+
_bazel_names := "BUILD,WORKSPACE,*.bazel,*.bzl,*.sky,*.star"
2829

2930
_bazel_excluded := ".git/*,*/.git/*,*misc/bazel/3rdparty/*_deps/*"
3031

0 commit comments

Comments
 (0)