Skip to content

Commit fd05c30

Browse files
redsun82Copilot
andcommitted
Just: say that buildifier's tally is kept on purpose
The count grows with the tree and is mostly docstring lint, so the first reading of it at any size invites putting the filter back. Name the lever that makes it quieter without taking the warnings worth having with it. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
1 parent 5729b43 commit fd05c30

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

misc/just/README.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,14 @@ Nothing is lost by this, as a banner has never been something to paste: the echo
162162
carried an unexpanded `"$@"`, which matches no file in another shell, so pasting one
163163
formatted nothing and exited 0.
164164

165+
What a formatter says for itself is filtered down to what happened, as several name every
166+
file they considered and most of them were left alone. One such line is kept on purpose:
167+
buildifier's count of the warnings it could not fix, which is the only notice of them,
168+
since it reports no detail in fix mode and exits 0 whether or not any remain. That tally
169+
grows with the tree and is mostly lint about docstrings. Finding it tiresome is a reason
170+
to configure what buildifier lints, never to widen the filter back over it, which would
171+
take the warnings worth having along with the rest.
172+
165173
Measuring the width means a `shell()` call, and that runs on every parse, so the result
166174
is exported as `JUST_CMD_RULE` and an inherited value is preferred to measuring again.
167175

0 commit comments

Comments
 (0)