Skip to content

Commit c01e76d

Browse files
redsun82Copilot
andcommitted
Just: say what setting the MSYS2 opt-out once costs
The comment gave the reason for centralising it and not the consequence: on Windows nothing a recipe runs gets path conversion any more, not just bazel. Someone adding a recipe needs that, and it is not visible from the assignment. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
1 parent c8bee28 commit c01e76d

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

misc/just/defs.just

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ export JUST_EXECUTABLE := just_executable()
1515
# MSYS2 rewrites arguments that look like paths as it hands them to a native program,
1616
# which mangles bazel's `//target` labels. Set once here rather than at each bazel call:
1717
# a call that forgets it works everywhere except Windows, which is where nobody looks.
18+
# The price of setting it once is that it covers every command a recipe runs, so a tool
19+
# that wants Windows path conversion has to ask for it back.
1820
export MSYS2_ARG_CONV_EXCL := if os() == "windows" { "*" } else { "" }
1921

2022
error := f'{{ style("error") }}error{{ NORMAL }}: '

0 commit comments

Comments
 (0)