Merge pull request #1029 from github/jeongsoolee09/MISRA-C++-Memory4

Add `Memory4` package

Author: jeongsoolee09

c/common/test/rules/objectassignedtoanoverlappingobject/ObjectAssignedToAnOverlappingObject.expected

@@ -0,0 +1 @@
+| test.c:36:3:36:18 | ... = ... | An object $@ assigned to overlapping object $@. | test.c:36:9:36:10 | m2 | m2 | test.c:36:17:36:18 | m1 | m1 |

c/common/test/rules/objectassignedtoanoverlappingobject/ObjectAssignedToAnOverlappingObject.ql

@@ -0,0 +1,4 @@
+// GENERATED FILE - DO NOT MODIFY
+import codingstandards.cpp.rules.objectassignedtoanoverlappingobject.ObjectAssignedToAnOverlappingObject
+
+class TestFileQuery extends ObjectAssignedToAnOverlappingObjectSharedQuery, TestQuery { }

c/common/test/rules/objectassignedtoanoverlappingobject/test.c

@@ -0,0 +1,53 @@
+struct s1 {
+  int m1[10];
+};
+struct s2 {
+  int m1;
+  struct s1 m2;
+};
+
+union u {
+  struct s1 m1;
+  struct s2 m2;
+};
+
+typedef struct {
+  char buf[8];
+} Union_t;
+
+typedef union {
+
+  unsigned char uc[24];
+
+  struct {
+    Union_t prefix;
+    Union_t suffix;
+  } fnv;
+
+  struct {
+    unsigned char padding[16];
+    Union_t suffix;
+  } diff;
+
+} UnionSecret_t;
+
+void overlapping_access() {
+  union u u1;
+  u1.m2.m2 = u1.m1; // NON_COMPLIANT, different struct. u1.m2 and u1.m1
+}
+
+void cross_copy() {
+  UnionSecret_t hash1;
+  hash1.diff.suffix =
+      hash1.fnv.suffix; // COMPLIANT (copy across structs), but safe.
+}
+
+void internal_shift() {
+  UnionSecret_t hash1;
+  hash1.fnv.prefix = hash1.fnv.suffix; // COMPLIANT, same struct.
+}
+
+void separate_access() {
+  UnionSecret_t hash1, hash2;
+  hash2.diff.suffix = hash1.fnv.suffix; // COMPLIANT, different union.
+}

…jectCopiedToAnOverlappingObject.expected …jectCopiedToAnOverlappingObject.expectedc/misra/test/rules/RULE-19-1/ObjectCopiedToAnOverlappingObject.expected renamed to c/common/test/rules/objectcopiedtoanoverlappingobject/ObjectCopiedToAnOverlappingObject.expected c/misra/test/rules/RULE-19-1/ObjectCopiedToAnOverlappingObject.expected renamed to c/common/test/rules/objectcopiedtoanoverlappingobject/ObjectCopiedToAnOverlappingObject.expected

@@ -0,0 +1,4 @@
+// GENERATED FILE - DO NOT MODIFY
+import codingstandards.cpp.rules.objectcopiedtoanoverlappingobject.ObjectCopiedToAnOverlappingObject
+
+class TestFileQuery extends ObjectCopiedToAnOverlappingObjectSharedQuery, TestQuery { }

c/common/test/rules/objectcopiedtoanoverlappingobject/ObjectCopiedToAnOverlappingObject.ql

@@ -56,4 +56,4 @@ void test_unions() {
 
   memcpy(&u1.m2.m2, &u1.m1, sizeof(u1.m1)); // NON_COMPLIANT
   memcpy(&u2.diff.suffix, &u2.fnv.suffix, sizeof(u2.fnv.suffix)); // COMPLIANT
-}
+}

c/misra/test/rules/RULE-19-1/test.c …objectcopiedtoanoverlappingobject/test.cc/misra/test/rules/RULE-19-1/test.c renamed to c/common/test/rules/objectcopiedtoanoverlappingobject/test.c c/misra/test/rules/RULE-19-1/test.c renamed to c/common/test/rules/objectcopiedtoanoverlappingobject/test.c

@@ -0,0 +1,23 @@
+/**
+ * @id c/misra/object-assigned-to-an-overlapping-object-misra-c
+ * @name RULE-19-1: An object shall not be assigned to an overlapping object
+ * @description An object shall not be copied or assigned to an overlapping object.
+ * @kind problem
+ * @precision high
+ * @problem.severity error
+ * @tags external/misra/id/rule-19-1
+ *       correctness
+ *       external/misra/c/2012/third-edition-first-revision
+ *       external/misra/obligation/mandatory
+ */
+
+import cpp
+import codingstandards.c.misra
+import codingstandards.cpp.rules.objectassignedtoanoverlappingobject.ObjectAssignedToAnOverlappingObject
+
+class ObjectAssignedToAnOverlappingObjectMisraCQuery extends ObjectAssignedToAnOverlappingObjectSharedQuery
+{
+  ObjectAssignedToAnOverlappingObjectMisraCQuery() {
+    this = Contracts7Package::objectAssignedToAnOverlappingObjectMisraCQuery()
+  }
+}

c/misra/src/rules/RULE-19-1/ObjectAssignedToAnOverlappingObject.ql

@@ -0,0 +1,23 @@
+/**
+ * @id c/misra/object-copied-to-an-overlapping-object-misra-c
+ * @name RULE-19-1: An object shall not be copied to an overlapping object
+ * @description An object shall not be copied to an overlapping object.
+ * @kind problem
+ * @precision high
+ * @problem.severity error
+ * @tags external/misra/id/rule-19-1
+ *       correctness
+ *       external/misra/c/2012/third-edition-first-revision
+ *       external/misra/obligation/mandatory
+ */
+
+import cpp
+import codingstandards.c.misra
+import codingstandards.cpp.rules.objectcopiedtoanoverlappingobject.ObjectCopiedToAnOverlappingObject
+
+class ObjectCopiedToAnOverlappingObjectMisraCQuery extends ObjectCopiedToAnOverlappingObjectSharedQuery
+{
+  ObjectCopiedToAnOverlappingObjectMisraCQuery() {
+    this = Contracts7Package::objectCopiedToAnOverlappingObjectMisraCQuery()
+  }
+}