git update-git-for-windows removes git\usr\bin from PATH that was added manually

[labo-pdc]

Existing issues matching what you're seeing

• I was not able to find an open or closed issue matching what I'm seeing

Git for Windows version

git version 2.55.0.vfs.0.8

Windows version

Windows 11

Windows CPU architecture

x86_64 (64-bit)

Additional Windows version information

Microsoft Windows [Version 10.0.26200.9106]

Options set during installation

Editor Option: Nano
Custom Editor Path: 
Default Branch Option:  
Path Option: Cmd
SSH Option: OpenSSH
Tortoise Option: false
CURL Option: WinSSL
CRLF Option: CRLFCommitAsIs
Bash Terminal Option: MinTTY
Git Pull Behavior Option: Merge
Use Credential Manager: Enabled
Performance Tweaks FSCache: Enabled
Enable Symlinks: Enabled
Enable FSMonitor: Disabled

Other interesting things

I installed git-for-windows via VFSForGit (https://github.com/microsoft/VFSForGit).

However, I expect that the git-for-windows is responsible, which is why I am posting here, but I could be wrong.

Terminal/shell

bash

Commands that trigger the issue

The issue occured when upgrading git-for-windows via update-git-for-windows.

During original install when asked for "Adjusting your PATH environment" I selected "Git from the command line and also from 3d-party software".
After the original install, I added the git\usr\bin to my user PATH manually as the last entry, such that .cmd scripts continue to use the Windows version of sort and find.
Finally I upgraded via git update-git-for-windows, which removed git\usr\bin in my user PATH.
I have upgraded git-for-windows several times, and it was only the most recent time that bash I noticed that my manually updated PATH got reverted, so I suspect that it is a regression in the installer.

As a sidenote, on the "Adjusting your PATH environment" page, I would suggest adding an option to add git\usr\bin to PATH after the last entry (or after c:\Windows\system32) as that is sufficient to avoid breaking .cmd scripts wrt. find and sort, and it allows .cmd scripts to use the other GNU tools included in git-for-windows.

Expected behaviour

I would expect git-for-windows to not remove entries from PATH that it did not add itself, especially during upgrades.

Actual behaviour

git update-git-for-windows removes git\usr\bin from PATH that was added manually

Repository

No response