Follow-up from #23443 (Isaac's review).
httpIntegration now exposes tracePropagation, matching Deno and nativeNodeFetchIntegration. Core's HttpInstrumentationOptions and Node's outgoing instrumentation still use propagateTrace. The Node integration maps between them:
propagateTrace: options.tracePropagation ?? true,
Goal
Pick one name and use it end-to-end (public integration options + core HttpInstrumentationOptions + Node outgoing instrumentation).
Recommendation
Keep tracePropagation as the public name — Deno and node-fetch already use it, and it sits next to tracePropagationTargets. Rename core/internal propagateTrace to match, rather than renaming the public option back to propagateTrace.
Do not conflate this with propagateTraceparent (W3C traceparent header) or tracePropagationTargets (which URLs get headers).
Scope
packages/core/src/integrations/http/types.ts (propagateTrace)
- Node
httpIntegration / OutgoingHttpRequestInstrumentationOptions
- Deno
httpIntegration (already tracePropagation publicly; still maps to propagateTrace)
- Call sites in
client-subscriptions, client-patch, tests, docs
This is a breaking change if we rename either exported option, so it belongs in 11.0 rather than a later minor.
Out of scope
propagateTraceparent and tracePropagationTargets stay as they are.
Follow-up from #23443 (Isaac's review).
httpIntegrationnow exposestracePropagation, matching Deno andnativeNodeFetchIntegration. Core'sHttpInstrumentationOptionsand Node's outgoing instrumentation still usepropagateTrace. The Node integration maps between them:Goal
Pick one name and use it end-to-end (public integration options + core
HttpInstrumentationOptions+ Node outgoing instrumentation).Recommendation
Keep
tracePropagationas the public name — Deno and node-fetch already use it, and it sits next totracePropagationTargets. Rename core/internalpropagateTraceto match, rather than renaming the public option back topropagateTrace.Do not conflate this with
propagateTraceparent(W3Ctraceparentheader) ortracePropagationTargets(which URLs get headers).Scope
packages/core/src/integrations/http/types.ts(propagateTrace)httpIntegration/OutgoingHttpRequestInstrumentationOptionshttpIntegration(alreadytracePropagationpublicly; still maps topropagateTrace)client-subscriptions,client-patch, tests, docsThis is a breaking change if we rename either exported option, so it belongs in 11.0 rather than a later minor.
Out of scope
propagateTraceparentandtracePropagationTargetsstay as they are.