Skip to content

Commit 2beb4b0

Browse files
msonnbcodex
andcommitted
test(browser): wait for image paint before finalizing LCP
Co-Authored-By: OpenAI ChatGPT <codex@openai.com>
1 parent 811c410 commit 2beb4b0

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

  • dev-packages/browser-integration-tests/suites/tracing/metrics/handlers-lcp

‎dev-packages/browser-integration-tests/suites/tracing/metrics/handlers-lcp/test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
import type { Route } from '@playwright/test';
77
import { expect } from '@playwright/test';
88
import { sentryTest } from '../../../../utils/fixtures';
9-
import { shouldSkipTracingTest } from '../../../../utils/helpers';
9+
import { shouldSkipTracingTest, waitForLcpCandidate } from '../../../../utils/helpers';
1010
import { getSpanOp, waitForStreamedSpan } from '../../../../utils/spanUtils';
1111

1212
const bundle = process.env.PW_BUNDLE || '';
@@ -27,7 +27,7 @@ sentryTest(
2727

2828
const lcpPromise = waitForStreamedSpan(page, span => getSpanOp(span) === 'ui.webvital.lcp');
2929
await page.goto(url);
30-
await page.waitForFunction('window._LCP === 107400 && window._LCP2 === 107400');
30+
await waitForLcpCandidate(page, 'img');
3131
await page.locator('button').click();
3232
const lcpSpan = await lcpPromise;
3333

0 commit comments

Comments
 (0)