fix(settings/ui): style fixes for settings components#100
Conversation
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThree files receive CSS styling updates: field component elements transition to inset-y-0-based vertical centering; the sidebar search icon adopts the same centering approach; and the sidebar menu components update active-state colors from sidebar-accent to primary-based values while removing a height constraint. ChangesUI Styling Refactor
🎯 1 (Trivial) | ⏱️ ~3 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Style fixes for settings UI components — vertical centering of icons/affixes and active-state styling for sidebar menu items.
Changes
fields.tsx— Replacetop-1/2 -translate-y-1/2centering withinset-y-0 flex items-centerfor the show/hide toggle button and number-field prefix/postfix spans. More robust vertical centering that doesn't depend on transform.settings-sidebar.tsx— Same centering fix for the search icon (inset-y-0 my-auto).sidebar.tsx:min-h-svhfrom the sidebar wrapper so it no longer forces full viewport height.bg-primary/10+text-primary(wasbg-sidebar-accent) for a clearer selected state.w-full, primary-tinted active state, active SVG color, andfont-mediumon active.Test plan
Summary by CodeRabbit