From e145a35af511c870752baf85c8082e6d39f1a79c Mon Sep 17 00:00:00 2001 From: forkwright Date: Wed, 26 Aug 2026 09:31:45 -0500 Subject: [PATCH] fix(kerykeion): drop the redundant Instrument import from collector_tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `collector.rs` declares `collector_tests.rs` as a child module via `#[cfg(test)] #[path = "collector_tests.rs"] mod tests;`, and the test file opens with `use super::*;`. That glob already re-exposes the parent's private `use tracing::{Instrument as _, instrument};`, so the file's own `use tracing::Instrument as _;` binds a name that is in scope either way. Under `RUSTFLAGS: -D warnings` the gate's `cargo check --workspace --all-targets` rejects it as `unused_imports`, failing `full-gate-build` and, downstream, `gate / gate`. The two `.instrument()` call sites keep resolving through `use super::*;`, and `collector.rs` keeps its own import — it uses both the trait and the `#[instrument(...)]` attribute directly. WARNING for whoever sees this recur: the same command over these byte-identical files passed on a main-push run 15 hours earlier under the same pinned toolchain. The import is unconditionally redundant, but its DETECTION is not deterministic — `Swatinem/rust-cache` shares one key across the push and pull_request triggers, so an incremental cache hit can skip re-linting this unit. A green run is therefore not evidence the lint is absent. --- crates/kerykeion/src/collector_tests.rs | 2 -- 1 file changed, 2 deletions(-) diff --git a/crates/kerykeion/src/collector_tests.rs b/crates/kerykeion/src/collector_tests.rs index 4eb98c0..3be23ae 100644 --- a/crates/kerykeion/src/collector_tests.rs +++ b/crates/kerykeion/src/collector_tests.rs @@ -1,8 +1,6 @@ //! Tests for [`super`]; split out to keep the parent file under the //! RUST/file-too-long 800-line threshold. -use tracing::Instrument as _; - use super::*; use crate::SendOptions; use crate::config::{ConnectionConfig, MeshConfig, StoreForwardConfig, TopologyConfig};