-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Open
Description
/build/_deps/fmt-src/include/fmt/base.h:2833:39: error: conversion to ‘int’ from ‘unsigned int’ may change the sign of the result [-Werror=sign-conversion] 2833 | detail::format_arg_store<context, sizeof...(T),
Lines 2401 to 2403 in bf3babf
| template <typename Context, int NUM_ARGS, int NUM_NAMED_ARGS, | |
| unsigned long long DESC> | |
| struct format_arg_store { |
I don't think that this should use int as the template parameter type, the arguments are typically unsigned as seen here:
Lines 2838 to 2841 in bf3babf
| using vargs = | |
| detail::format_arg_store<context, sizeof...(T), | |
| detail::count_named_args<T...>(), | |
| detail::make_descriptor<context, T...>()>; |
sizeof returns size_t and not int.
I'm also getting a ton of truncation warnings with 32 bit builds.
Metadata
Metadata
Assignees
Labels
No labels