Skip to content

Commit e1a7e07

Browse files
committed
tests should now pass
1 parent a18b6fd commit e1a7e07

3 files changed

Lines changed: 36 additions & 30 deletions

File tree

examples/4_performance_analysis.ipynb

Lines changed: 32 additions & 26 deletions
Large diffs are not rendered by default.

pynumdiff/kalman_smooth/_kalman_smooth.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ def constant_velocity(x, dt, params=None, options=None, r=None, q=None, forwardb
199199
raise ValueError("`q` and `r` must be given.")
200200

201201
warn("`constant_velocity` is deprecated. Call `rtsdiff` with order 1 instead.", DeprecationWarning)
202-
return rtsdiff(x, dt, 1, q/r, forwardbackward)
202+
return rtsdiff(x, dt, 1, np.log10(q/r), forwardbackward)
203203

204204

205205
def constant_acceleration(x, dt, params=None, options=None, r=None, q=None, forwardbackward=True):
@@ -230,7 +230,7 @@ def constant_acceleration(x, dt, params=None, options=None, r=None, q=None, forw
230230
raise ValueError("`q` and `r` must be given.")
231231

232232
warn("`constant_acceleration` is deprecated. Call `rtsdiff` with order 2 instead.", DeprecationWarning)
233-
return rtsdiff(x, dt, 2, q/r, forwardbackward)
233+
return rtsdiff(x, dt, 2, np.log10(q/r), forwardbackward)
234234

235235

236236
def constant_jerk(x, dt, params=None, options=None, r=None, q=None, forwardbackward=True):
@@ -261,7 +261,7 @@ def constant_jerk(x, dt, params=None, options=None, r=None, q=None, forwardbackw
261261
raise ValueError("`q` and `r` must be given.")
262262

263263
warn("`constant_jerk` is deprecated. Call `rtsdiff` with order 3 instead.", DeprecationWarning)
264-
return rtsdiff(x, dt, 3, q/r, forwardbackward)
264+
return rtsdiff(x, dt, 3, np.log10(q/r), forwardbackward)
265265

266266

267267
def robustdiff(x, dt, order, log_q, log_r, proc_huberM=6, meas_huberM=1.345):

pynumdiff/tests/test_diff_methods.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def spline_irreg_step(*args, **kwargs): return splinediff(*args, **kwargs)
5050
(constant_velocity, {'r':1e-2, 'q':1e3}), (constant_velocity, [1e-2, 1e3]),
5151
(constant_acceleration, {'r':1e-3, 'q':1e4}), (constant_acceleration, [1e-3, 1e4]),
5252
(constant_jerk, {'r':1e-4, 'q':1e5}), (constant_jerk, [1e-4, 1e5]),
53-
(rtsdiff, {'order':2, 'qr_ratio':1e7, 'forwardbackward':True}),
53+
(rtsdiff, {'order':2, 'log_qr_ratio':7, 'forwardbackward':True}),
5454
#(robustdiff, {'order':3, 'qr_ratio':1e8}), # Add back later, once the design stabilizes
5555
(velocity, {'gamma':0.5}), (velocity, [0.5]),
5656
(acceleration, {'gamma':1}), (acceleration, [1]),

0 commit comments

Comments
 (0)