From 19f37fb2d9ba54e5070418313a3f69976b0d0919 Mon Sep 17 00:00:00 2001 From: LasseLegarth Date: Mon, 16 Nov 2026 13:01:40 +0100 Subject: [PATCH] fix(core,appcheck,web): start when the browser blocks web storage When the user blocks site data, accessing window.sessionStorage or window.localStorage throws a SecurityError. Several web startup paths accessed them unguarded, so Firebase.initializeApp threw and the app never started (blank page): - firebase_core_web read sessionStorage while registering library versions. - firebase_app_check_web read the persisted reCAPTCHA settings in ensurePluginInitialized, and activate() wrote them back. Both are caches for the next startup or for de-duplication, so blocked storage is now treated as "nothing persisted" and writes are skipped. firebase_auth_web already handles blocked storage since #18926. Its browser test is kept to cover initializeApp and useAuthEmulator with storage blocked. --- .../lib/firebase_app_check_web.dart | 56 +++++++----- .../test/blocked_web_storage_test.dart | 88 ++++++++++++++++++ .../test/blocked_web_storage_test.dart | 83 +++++++++++++++++ .../lib/src/firebase_core_web.dart | 10 +- ...irebase_core_web_blocked_storage_test.dart | 91 +++++++++++++++++++ 5 files changed, 304 insertions(+), 24 deletions(-) create mode 100644 packages/firebase_app_check/firebase_app_check_web/test/blocked_web_storage_test.dart create mode 100644 packages/firebase_auth/firebase_auth_web/test/blocked_web_storage_test.dart create mode 100644 packages/firebase_core/firebase_core_web/test/firebase_core_web_blocked_storage_test.dart diff --git a/packages/firebase_app_check/firebase_app_check_web/lib/firebase_app_check_web.dart b/packages/firebase_app_check/firebase_app_check_web/lib/firebase_app_check_web.dart index 7aa52006f03e..49e6e2a10a8a 100644 --- a/packages/firebase_app_check/firebase_app_check_web/lib/firebase_app_check_web.dart +++ b/packages/firebase_app_check/firebase_app_check_web/lib/firebase_app_check_web.dart @@ -43,21 +43,30 @@ class FirebaseAppCheckWeb extends FirebaseAppCheckPlatform { final instance = FirebaseAppCheckWeb( app: Firebase.app(firebaseApp.name), ); - var recaptchaType = web.window.localStorage.getItem( - _sessionKeyRecaptchaType(firebaseApp.name), - ); - var recaptchaSiteKey = web.window.localStorage.getItem( - _sessionKeyRecaptchaSiteKey(firebaseApp.name), - ); - - // For backwards compatibility, with previously used session storage - if (recaptchaType == null || recaptchaSiteKey == null) { - recaptchaType = web.window.sessionStorage.getItem( + String? recaptchaType; + String? recaptchaSiteKey; + try { + recaptchaType = web.window.localStorage.getItem( _sessionKeyRecaptchaType(firebaseApp.name), ); - recaptchaSiteKey = web.window.sessionStorage.getItem( + recaptchaSiteKey = web.window.localStorage.getItem( _sessionKeyRecaptchaSiteKey(firebaseApp.name), ); + + // For backwards compatibility, with previously used session storage + if (recaptchaType == null || recaptchaSiteKey == null) { + recaptchaType = web.window.sessionStorage.getItem( + _sessionKeyRecaptchaType(firebaseApp.name), + ); + recaptchaSiteKey = web.window.sessionStorage.getItem( + _sessionKeyRecaptchaSiteKey(firebaseApp.name), + ); + } + } catch (_) { + // Accessing web storage throws a SecurityError when the user blocks + // site data. Nothing can have been persisted then. + recaptchaType = null; + recaptchaSiteKey = null; } if (recaptchaType != null) { @@ -141,16 +150,21 @@ class FirebaseAppCheckWeb extends FirebaseAppCheckPlatform { } else { throw Exception('Invalid web provider: $providerWeb'); } - web.window.localStorage.setItem( - _sessionKeyRecaptchaType(app.name), - recaptchaType, - ); - web.window.localStorage.setItem( - _sessionKeyRecaptchaSiteKey(app.name), - providerWeb is WebDebugProvider - ? providerWeb.debugToken ?? '' - : providerWeb.siteKey, - ); + try { + web.window.localStorage.setItem( + _sessionKeyRecaptchaType(app.name), + recaptchaType, + ); + web.window.localStorage.setItem( + _sessionKeyRecaptchaSiteKey(app.name), + providerWeb is WebDebugProvider + ? providerWeb.debugToken ?? '' + : providerWeb.siteKey, + ); + } catch (_) { + // Accessing web storage throws a SecurityError when the user blocks + // site data. Persisting is only for the next startup, so continue. + } } // activate API no longer exists, recaptcha key has to be passed on initialization of app-check instance. diff --git a/packages/firebase_app_check/firebase_app_check_web/test/blocked_web_storage_test.dart b/packages/firebase_app_check/firebase_app_check_web/test/blocked_web_storage_test.dart new file mode 100644 index 000000000000..0e53aa75b821 --- /dev/null +++ b/packages/firebase_app_check/firebase_app_check_web/test/blocked_web_storage_test.dart @@ -0,0 +1,88 @@ +// Copyright 2026 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +@TestOn('browser') +library; + +import 'dart:js_interop'; + +import 'package:firebase_app_check_platform_interface/firebase_app_check_platform_interface.dart'; +import 'package:firebase_app_check_web/firebase_app_check_web.dart'; +import 'package:firebase_core/firebase_core.dart'; +import 'package:firebase_core_platform_interface/firebase_core_platform_interface.dart'; +import 'package:firebase_core_web/firebase_core_web.dart'; +import 'package:flutter_test/flutter_test.dart'; +import 'package:flutter_web_plugins/flutter_web_plugins.dart'; + +@JS('eval') +external JSAny? _eval(String code); + +/// Makes `window.sessionStorage` and `window.localStorage` throw like they do +/// when the user has blocked site data for the origin. +void _blockWebStorage() { + _eval(r''' + window.__savedWebStorage = {}; + for (const name of ['sessionStorage', 'localStorage']) { + window.__savedWebStorage[name] = + Object.getOwnPropertyDescriptor(window, name); + Object.defineProperty(window, name, { + configurable: true, + get() { + throw new DOMException( + `Failed to read the '${name}' property from 'Window': ` + + 'Access is denied for this document.', + 'SecurityError', + ); + }, + }); + } + '''); +} + +void _restoreWebStorage() { + _eval(''' + for (const [name, descriptor] of Object.entries(window.__savedWebStorage)) { + Object.defineProperty(window, name, descriptor); + } + delete window.__savedWebStorage; + '''); +} + +void main() { + group('FirebaseAppCheckWeb with web storage blocked', () { + setUpAll(() { + FirebasePlatform.instance = FirebaseCoreWeb(); + FirebaseAppCheckWeb.registerWith(webPluginRegistrar); + }); + + setUp(_blockWebStorage); + + tearDown(_restoreWebStorage); + + test('initializeApp with App Check succeeds', () async { + const options = FirebaseOptions( + apiKey: 'fake-api-key', + appId: '1:1234567890:web:fake', + messagingSenderId: '1234567890', + projectId: 'fake-project', + ); + + await expectLater( + FirebasePlatform.instance.initializeApp(options: options), + completes, + ); + }); + + test('activate succeeds', () async { + final appCheck = FirebaseAppCheckWeb(app: Firebase.app()); + + await expectLater( + appCheck.activate( + providerWeb: WebDebugProvider(debugToken: 'fake-debug-token'), + ), + completes, + ); + }); + }); +} diff --git a/packages/firebase_auth/firebase_auth_web/test/blocked_web_storage_test.dart b/packages/firebase_auth/firebase_auth_web/test/blocked_web_storage_test.dart new file mode 100644 index 000000000000..47f41d704524 --- /dev/null +++ b/packages/firebase_auth/firebase_auth_web/test/blocked_web_storage_test.dart @@ -0,0 +1,83 @@ +// Copyright 2026 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +@TestOn('browser') +library; + +import 'dart:js_interop'; + +import 'package:firebase_auth_web/firebase_auth_web.dart'; +import 'package:firebase_core/firebase_core.dart'; +import 'package:firebase_core_platform_interface/firebase_core_platform_interface.dart'; +import 'package:firebase_core_web/firebase_core_web.dart'; +import 'package:flutter_test/flutter_test.dart'; +import 'package:flutter_web_plugins/flutter_web_plugins.dart'; + +@JS('eval') +external JSAny? _eval(String code); + +/// Makes `window.sessionStorage` and `window.localStorage` throw like they do +/// when the user has blocked site data for the origin. +void _blockWebStorage() { + _eval(r''' + window.__savedWebStorage = {}; + for (const name of ['sessionStorage', 'localStorage']) { + window.__savedWebStorage[name] = + Object.getOwnPropertyDescriptor(window, name); + Object.defineProperty(window, name, { + configurable: true, + get() { + throw new DOMException( + `Failed to read the '${name}' property from 'Window': ` + + 'Access is denied for this document.', + 'SecurityError', + ); + }, + }); + } + '''); +} + +void _restoreWebStorage() { + _eval(''' + for (const [name, descriptor] of Object.entries(window.__savedWebStorage)) { + Object.defineProperty(window, name, descriptor); + } + delete window.__savedWebStorage; + '''); +} + +void main() { + group('FirebaseAuthWeb with web storage blocked', () { + setUpAll(() { + FirebasePlatform.instance = FirebaseCoreWeb(); + FirebaseAuthWeb.registerWith(webPluginRegistrar); + }); + + setUp(_blockWebStorage); + + tearDown(_restoreWebStorage); + + test('initializeApp with Auth succeeds', () async { + const options = FirebaseOptions( + apiKey: 'fake-api-key', + appId: '1:1234567890:web:fake', + messagingSenderId: '1234567890', + projectId: 'fake-project', + authDomain: 'fake-project.firebaseapp.com', + ); + + await expectLater( + FirebasePlatform.instance.initializeApp(options: options), + completes, + ); + }); + + test('useAuthEmulator succeeds', () async { + final auth = FirebaseAuthWeb(app: Firebase.app()); + + await expectLater(auth.useAuthEmulator('localhost', 9099), completes); + }); + }); +} diff --git a/packages/firebase_core/firebase_core_web/lib/src/firebase_core_web.dart b/packages/firebase_core/firebase_core_web/lib/src/firebase_core_web.dart index 41b2000c9a34..c1d10787059a 100644 --- a/packages/firebase_core/firebase_core_web/lib/src/firebase_core_web.dart +++ b/packages/firebase_core/firebase_core_web/lib/src/firebase_core_web.dart @@ -77,11 +77,15 @@ class FirebaseCoreWeb extends FirebasePlatform { String packageVersion, ) { final sessionKey = 'flutterfire-$libraryName-$packageVersion'; - final sessionItem = web.window.sessionStorage.getItem(sessionKey); - if (sessionItem == null) { + try { + if (web.window.sessionStorage.getItem(sessionKey) != null) return; web.window.sessionStorage.setItem(sessionKey, packageVersion); - firebase.registerVersion(libraryName, packageVersion); + } catch (_) { + // Accessing `window.sessionStorage` throws a SecurityError when the user + // blocks site data. The cache only avoids duplicate registrations, so + // register anyway instead of failing `initializeApp`. } + firebase.registerVersion(libraryName, packageVersion); } static void registerLibraryVersion(String libraryName, String version) { diff --git a/packages/firebase_core/firebase_core_web/test/firebase_core_web_blocked_storage_test.dart b/packages/firebase_core/firebase_core_web/test/firebase_core_web_blocked_storage_test.dart new file mode 100644 index 000000000000..5a4ab4db1101 --- /dev/null +++ b/packages/firebase_core/firebase_core_web/test/firebase_core_web_blocked_storage_test.dart @@ -0,0 +1,91 @@ +// Copyright 2026 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +@TestOn('browser') +library; + +import 'dart:js_interop'; +import 'dart:js_interop_unsafe'; + +import 'package:firebase_core_platform_interface/firebase_core_platform_interface.dart'; +import 'package:firebase_core_web/firebase_core_web.dart'; +import 'package:flutter_test/flutter_test.dart'; + +@JS('eval') +external JSAny? _eval(String code); + +/// Makes `window.sessionStorage` and `window.localStorage` throw like they do +/// when the user has blocked site data for the origin. +void _blockWebStorage() { + _eval(r''' + window.__savedWebStorage = {}; + for (const name of ['sessionStorage', 'localStorage']) { + window.__savedWebStorage[name] = + Object.getOwnPropertyDescriptor(window, name); + Object.defineProperty(window, name, { + configurable: true, + get() { + throw new DOMException( + `Failed to read the '${name}' property from 'Window': ` + + 'Access is denied for this document.', + 'SecurityError', + ); + }, + }); + } + '''); +} + +void _restoreWebStorage() { + _eval(''' + for (const [name, descriptor] of Object.entries(window.__savedWebStorage)) { + Object.defineProperty(window, name, descriptor); + } + delete window.__savedWebStorage; + '''); +} + +String _getPlatformInfoString() { + final core = globalContext.getProperty('firebase_core'.toJS); + final jsApp = core.callMethod('getApp'.toJS); + final container = jsApp.getProperty('container'.toJS); + final provider = container.callMethod( + 'getProvider'.toJS, + 'platform-logger'.toJS, + ); + final logger = provider.callMethod('getImmediate'.toJS); + return logger.callMethod('getPlatformInfoString'.toJS).toDart; +} + +void main() { + group('FirebaseCoreWeb with web storage blocked', () { + setUp(() { + FirebasePlatform.instance = FirebaseCoreWeb(); + _blockWebStorage(); + }); + + tearDown(_restoreWebStorage); + + test( + 'initializeApp succeeds and still registers library versions', + () async { + const options = FirebaseOptions( + apiKey: 'fake-api-key', + appId: '1:1234567890:web:fake', + messagingSenderId: '1234567890', + projectId: 'fake-project', + ); + + await FirebasePlatform.instance.initializeApp(options: options); + expect(_getPlatformInfoString(), contains('flutter-fire-core/')); + + FirebaseCoreWeb.registerLibraryVersion('flutter-fire-blocked', '1.0.0'); + expect( + _getPlatformInfoString(), + contains('flutter-fire-blocked/1.0.0'), + ); + }, + ); + }); +}