From 0db46cfe86b7bda97389e7efe75a00ea6aec2874 Mon Sep 17 00:00:00 2001
From: "google-labs-jules[bot]"
 <161369871+google-labs-jules[bot]@users.noreply.github.com>
Date: Wed, 18 Feb 2026 19:25:47 +0000
Subject: [PATCH] perf: Avoid unnecessary String construction in
 CustomClassMapper

This change optimizes the CustomClassMapper by avoiding the construction
of the "No setter/field" error message when both throwOnUnknownProperties
and warnOnUnknownProperties are false. This scenario occurs commonly
when using @IgnoreExtraProperties.

Benchmark results show a ~28x improvement for deserializing objects with
many unknown properties.

Co-authored-by: lahirumaramba <55609+lahirumaramba@users.noreply.github.com>
---
 .../utilities/encoding/CustomClassMapper.java | 28 ++++++++++---------
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/src/main/java/com/google/firebase/database/utilities/encoding/CustomClassMapper.java b/src/main/java/com/google/firebase/database/utilities/encoding/CustomClassMapper.java
index d4ba951e7..152d7a780 100644
--- a/src/main/java/com/google/firebase/database/utilities/encoding/CustomClassMapper.java
+++ b/src/main/java/com/google/firebase/database/utilities/encoding/CustomClassMapper.java
@@ -730,19 +730,21 @@ public T deserialize(Map<String, Object> values, Map<TypeVariable<Class<T>>, Typ
             throw new RuntimeException(e);
           }
         } else {
-          String message =
-              "No setter/field for "
-                  + propertyName
-                  + " found "
-                  + "on class "
-                  + this.clazz.getName();
-          if (this.properties.containsKey(propertyName.toLowerCase())) {
-            message += " (fields/setters are case sensitive!)";
-          }
-          if (this.throwOnUnknownProperties) {
-            throw new DatabaseException(message);
-          } else if (this.warnOnUnknownProperties) {
-            logger.warn(message);
+          if (this.throwOnUnknownProperties || this.warnOnUnknownProperties) {
+            String message =
+                "No setter/field for "
+                    + propertyName
+                    + " found "
+                    + "on class "
+                    + this.clazz.getName();
+            if (this.properties.containsKey(propertyName.toLowerCase())) {
+              message += " (fields/setters are case sensitive!)";
+            }
+            if (this.throwOnUnknownProperties) {
+              throw new DatabaseException(message);
+            } else if (this.warnOnUnknownProperties) {
+              logger.warn(message);
+            }
           }
         }
       }