Skip to content

[rust-compiler] Skip empty optional ScopeInfo maps on serialize #36520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
poteto wants to merge 1 commit into from
Closed

[rust-compiler] Skip empty optional ScopeInfo maps on serialize #36520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions compiler/crates/react_compiler_ast/src/scope.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ pub struct ScopeInfo {
/// Parallel to node_to_scope — same keys, but stores the end position
/// of the scope-creating AST node. Used to determine if a source position
/// falls within a particular scope's AST range.
#[serde(default)]
#[serde(default, skip_serializing_if = "HashMap::is_empty")]
pub node_to_scope_end: HashMap<u32, u32>,

/// Maps an Identifier AST node's start offset to the binding it resolves to.
Expand All @@ -126,11 +126,19 @@ pub struct ScopeInfo {
/// Maps an identifier reference's node-ID to the binding it resolves to.
/// Only present for identifiers that resolve to a binding (not globals).
/// Uses IndexMap to preserve insertion order.
#[serde(default, rename = "refNodeIdToBinding")]
#[serde(
default,
rename = "refNodeIdToBinding",
skip_serializing_if = "IndexMap::is_empty"
)]
pub ref_node_id_to_binding: IndexMap<u32, BindingId>,

/// Maps a scope-creating AST node's node-ID to the scope it creates.
#[serde(default, rename = "nodeIdToScope")]
#[serde(
default,
rename = "nodeIdToScope",
skip_serializing_if = "HashMap::is_empty"
)]
pub node_id_to_scope: HashMap<u32, ScopeId>,

/// The program-level (module) scope. Always scopes[0].
Expand Down
Loading