Fix deprecation warnings in NetworkEventUtilTest#56954
Open
Abbondanzo wants to merge 1 commit into
Open
Conversation
Summary: Android builds have been failing with the following: ``` > Task :packages:react-native:ReactAndroid:compileDebugOptimizedUnitTestKotlin e: warnings found and -Werror specified w: file:///__w/react-native/react-native/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/network/NetworkEventUtilTest.kt:309:28 'fun create(contentType: MediaType?, content: String): RequestBody' is deprecated. Moved to extension function. Put the 'content' argument first to fix Java. w: file:///__w/react-native/react-native/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/network/NetworkEventUtilTest.kt:317:29 'fun create(contentType: MediaType?, content: String): RequestBody' is deprecated. Moved to extension function. Put the 'content' argument first to fix Java. ``` Warnings show as errors but we're not on OkHttp 4 yet and don't have extension functions, so it's fine to suppress these for now. Changelog: [Internal] Differential Revision: D106200232
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106200232. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Android builds have been failing with the following:
Warnings show as errors but we're not on OkHttp 4 yet and don't have extension functions, so it's fine to suppress these for now.
Changelog: [Internal]
Differential Revision: D106200232