You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Aug 19, 2025. It is now read-only.
maybe moving the _backend.subscribe call outside the try block: when that call fails you can probably skip self._backend.unsubscribe. You'd still need to put a None in the queue though.
I could prepare a PR with any of those if they make sense.
Hi maintainers, thank you for the package !
This line can fail with a
ConnectionError, at least when using the Redis backend, possibly others too:broadcaster/broadcaster/_base.py
Line 95 in 69cf29a
When that happens,
queueis never added toself._subscribers[channel].But the
finallyblock will try to remove it nonetheless, causing aKeyErrorand hiding the original issue:broadcaster/broadcaster/_base.py
Line 102 in 69cf29a
Possible solutions:
discardinstead ofremove_backend.subscribecall outside thetryblock: when that call fails you can probably skipself._backend.unsubscribe. You'd still need to put aNonein the queue though.I could prepare a PR with any of those if they make sense.