Trouble with emcc 6.0.0 from #25930

[hoodmane]

I'm not 100% sure what the problem is but emcc 6.0.0 works fine for me if I revert #25930. The problem is that -Bstatic is passed when I'm trying to link a static library.

I think the problem is that the condition here is wrong:

  if settings.FAKE_DYLIBS or (not settings.MAIN_MODULE and not settings.SIDE_MODULE):
    cmd.append('-Bstatic')
  else:
    # wasm-ld still defaults to static linking by default. If that ever changes, we can remove this line.
    cmd.append('-Bdynamic')

emscripten/tools/building.py

Lines 167 to 172 in 6d8b2c1

	if settings.FAKE_DYLIBS or (not settings.MAIN_MODULE and not settings.SIDE_MODULE):
	cmd.append('-Bstatic')
	else:
	# wasm-ld still defaults to static linking by default. If that ever changes, we can remove this line.
	cmd.append('-Bdynamic')

[hoodmane]

Maybe it should be:

if settings.FAKE_DYLIBS and (not settings.MAIN_MODULE and not settings.SIDE_MODULE): 

[hoodmane]

Well this patch:

   if settings.FAKE_DYLIBS or (not settings.MAIN_MODULE and not settings.SIDE_MODULE):
-    cmd.append('-Bstatic')
+    pass

fixes the build but it still breaks at runtime.

[sbc100]

Do you know why passing -Bstatic would be a problem when linking a static library? Are you passing either -Bstatic or -Bdynamic yourself, or are we just talking about the internal injection of these flags?

[hoodmane]

It's trying to link a shared library into a static library and failing. Either they should both be dynamic or both be static and I'm not sure which. Perhaps it involves some strange combination of flags which work on more standard linkers.

[sbc100]

Do you want what the intent of the build is? Maybe you should share the full build command that is being used to build this library (either the emcc or the host version).

I'm a little confused what you mean by "trying to link a shared library into a static library and failing" since static libraries are not linked at all using emcc right? They use emar