From 490a57564096d57657e365ee1dae401fe52d2c5d Mon Sep 17 00:00:00 2001 From: Ed Savage Date: Thu, 17 Sep 2026 13:24:09 +1200 Subject: [PATCH 1/3] [ML] Enforce zero warnings in debug Linux CI build Add -DCMAKE_COMPILE_WARNING_AS_ERROR=ON to the debug Linux x86_64 CI build step. PR #2985 reduced compiler warnings to zero on this configuration; this flag makes any regression an immediate build failure rather than a silent accumulation. The flag is scoped to the existing debug PR build step only, leaving release and cross-compile configurations unchanged. Co-Authored-By: Claude Sonnet 4.6 --- .buildkite/pipelines/build_linux.json.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.buildkite/pipelines/build_linux.json.py b/.buildkite/pipelines/build_linux.json.py index 913e8e154..eed269d4c 100755 --- a/.buildkite/pipelines/build_linux.json.py +++ b/.buildkite/pipelines/build_linux.json.py @@ -237,7 +237,7 @@ def main(args): "env": { **common_env, "ML_DEBUG": "1", - "CMAKE_FLAGS": "-DCMAKE_TOOLCHAIN_FILE=cmake/linux-x86_64.cmake -DML_FAST_DEBUG=ON -DCMAKE_UNITY_BUILD=ON -DML_PCH=ON", + "CMAKE_FLAGS": "-DCMAKE_TOOLCHAIN_FILE=cmake/linux-x86_64.cmake -DML_FAST_DEBUG=ON -DCMAKE_UNITY_BUILD=ON -DML_PCH=ON -DCMAKE_COMPILE_WARNING_AS_ERROR=ON", "RUN_TESTS": "false", "SKIP_ARTIFACT_UPLOAD": "true", }, From 1eab514c6f61c0a2975045883ad305825cad519e Mon Sep 17 00:00:00 2001 From: Ed Savage Date: Thu, 17 Sep 2026 15:21:13 +1200 Subject: [PATCH 2/3] [ML] Temporary: deliberate warning to test -Werror enforcement (revert me) --- lib/ver/CBuildInfo.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ver/CBuildInfo.cc b/lib/ver/CBuildInfo.cc index c1c916bdc..5f5870276 100644 --- a/lib/ver/CBuildInfo.cc +++ b/lib/ver/CBuildInfo.cc @@ -13,6 +13,8 @@ #include #include +#warning "deliberate test warning to verify -Werror enforcement — remove before merging" + namespace ml { namespace ver { From 7818f32312cfdadaf9e4645e71e9b0e8ffab3000 Mon Sep 17 00:00:00 2001 From: Ed Savage Date: Thu, 17 Sep 2026 15:34:34 +1200 Subject: [PATCH 3/3] Revert "[ML] Temporary: deliberate warning to test -Werror enforcement (revert me)" This reverts commit 1eab514c6f61c0a2975045883ad305825cad519e. --- lib/ver/CBuildInfo.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/ver/CBuildInfo.cc b/lib/ver/CBuildInfo.cc index 5f5870276..c1c916bdc 100644 --- a/lib/ver/CBuildInfo.cc +++ b/lib/ver/CBuildInfo.cc @@ -13,8 +13,6 @@ #include #include -#warning "deliberate test warning to verify -Werror enforcement — remove before merging" - namespace ml { namespace ver {