Skip to content

Angular build floods with ESM warnings #2599

Description

@pedroestabruxelles

Describe the bug

Not sure if should report as a bug but from my point of view it's an issue that should be addressed.

At the moment when building the angular project (v20) I'm being flooded with "X package is not ESM" coming from this package.
We use lodash-es and this also means we will have two times the lodash package.
lodash is not the only culprit: "avj" and "dayjs". We don't use dayjs not sure why this is being included on the bundle.

Looking forward to see how we can proceed with fixing this, I could help on some parts.


Imports flagged

[WARNING] Module 'lodash/cloneDeep' used by 'node_modules/@jsonforms/angular/lib/fesm2022/jsonforms-angular.mjs' is not ESM
[WARNING] Module 'lodash/merge' used by 'node_modules/@jsonforms/angular/lib/fesm2022/jsonforms-angular.mjs' is not ESM
[WARNING] Module 'lodash/maxBy' used by 'node_modules/@jsonforms/angular/lib/fesm2022/jsonforms-angular.mjs' is not ESM
[WARNING] Module 'lodash/isEqual' used by 'node_modules/@jsonforms/angular/lib/fesm2022/jsonforms-angular.mjs' is not ESM
[WARNING] Module 'lodash/get' used by 'node_modules/@jsonforms/angular/lib/fesm2022/jsonforms-angular.mjs' is not ESM
[WARNING] Module 'lodash/isEmpty' used by 'node_modules/@jsonforms/core/lib/jsonforms-core.esm.js' is not ESM
[WARNING] Module 'lodash/startCase' used by 'node_modules/@jsonforms/core/lib/jsonforms-core.esm.js' is not ESM
[WARNING] Module 'lodash/keys' used by 'node_modules/@jsonforms/core/lib/jsonforms-core.esm.js' is not ESM
[WARNING] Module 'lodash/range' used by 'node_modules/@jsonforms/core/lib/jsonforms-core.esm.js' is not ESM
[WARNING] Module 'lodash/has' used by 'node_modules/@jsonforms/core/lib/jsonforms-core.esm.js' is not ESM
[WARNING] Module 'lodash/find' used by 'node_modules/@jsonforms/core/lib/jsonforms-core.esm.js' is not ESM
[WARNING] Module 'lodash/includes' used by 'node_modules/@jsonforms/core/lib/jsonforms-core.esm.js' is not ESM
[WARNING] Module 'ajv' used by 'node_modules/@jsonforms/core/lib/jsonforms-core.esm.js' is not ESM
[WARNING] Module 'ajv-formats' used by 'node_modules/@jsonforms/core/lib/jsonforms-core.esm.js' is not ESM
[WARNING] Module 'lodash/filter' used by 'node_modules/@jsonforms/core/lib/jsonforms-core.esm.js' is not ESM
[WARNING] Module 'lodash/fp/set' used by 'node_modules/@jsonforms/core/lib/jsonforms-core.esm.js' is not ESM
[WARNING] Module 'lodash/fp/unset' used by 'node_modules/@jsonforms/core/lib/jsonforms-core.esm.js' is not ESM
[WARNING] Module 'lodash/isFunction' used by 'node_modules/@jsonforms/core/lib/jsonforms-core.esm.js' is not ESM
[WARNING] Module 'lodash/remove' used by 'node_modules/@jsonforms/core/lib/jsonforms-core.esm.js' is not ESM
[WARNING] Module 'lodash/endsWith' used by 'node_modules/@jsonforms/core/lib/jsonforms-core.esm.js' is not ESM
[WARNING] Module 'lodash/last' used by 'node_modules/@jsonforms/core/lib/jsonforms-core.esm.js' is not ESM
[WARNING] Module 'lodash/reduce' used by 'node_modules/@jsonforms/core/lib/jsonforms-core.esm.js' is not ESM
[WARNING] Module 'lodash/toPairs' used by 'node_modules/@jsonforms/core/lib/jsonforms-core.esm.js' is not ESM
[WARNING] Module 'lodash/isUndefined' used by 'node_modules/@jsonforms/core/lib/jsonforms-core.esm.js' is not ESM
[WARNING] Module 'dayjs' used by 'node_modules/@jsonforms/angular-material/lib/fesm2022/jsonforms-angular-material.mjs' is not ESM
[WARNING] Module 'dayjs/plugin/customParseFormat' used by 'node_modules/@jsonforms/angular-material/lib/fesm2022/jsonforms-angular-material.mjs' is not ESM
[WARNING] Module 'lodash/some' used by 'node_modules/@jsonforms/angular-material/lib/fesm2022/jsonforms-angular-material.mjs' is not ESM

Expected behavior

Not have ESM build warnings, better manage which packages are being included

Steps to reproduce the issue

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots

Image Image Image

Which Version of JSON Forms are you using?

3.8.0

Package

Angular Bindings

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions