From 057a2242678e26c4d4193c8531d658845d4e611c Mon Sep 17 00:00:00 2001 From: Shahzaib Ibrahim Date: Mon, 19 Jan 2026 11:18:52 +0100 Subject: [PATCH] Use OfFloat Point values to create precise highlight brackets Because of rounding errors the bracket selection highlight is often inconsistent. Making use of residual values provides precise rectangle values and highlight is consistent across all zooms --- .../jface/text/source/MatchingCharacterPainter.java | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/source/MatchingCharacterPainter.java b/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/source/MatchingCharacterPainter.java index f63a54c6c1d6..85a2b460d5bd 100644 --- a/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/source/MatchingCharacterPainter.java +++ b/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/source/MatchingCharacterPainter.java @@ -257,17 +257,14 @@ private void draw(final GC gc, final int offset) { if (gc != null) { gc.setForeground(fColor); - final Rectangle bounds= fTextWidget.getTextBounds(offset, offset); + Point offsetLocation= fTextWidget.getLocationAtOffset(offset); - // determine the character width separately, because the getTextBounds above - // will also include any in-line annotations (e.g. codemining annotations) in the width final String matchingCharacter= fTextWidget.getText(offset, offset); - final int width= gc.textExtent(matchingCharacter).x; - - final int height= fTextWidget.getCaret().getSize().y; + Point characterBounds= gc.textExtent(matchingCharacter); + Rectangle hightlightingArea= Rectangle.of(offsetLocation, characterBounds); // draw box around line segment - gc.drawRectangle(bounds.x, bounds.y + bounds.height - height, width, height - 1); + gc.drawRectangle(hightlightingArea); } else { fTextWidget.redrawRange(offset, 1, true); }