Windows 11 - Selected Toolbar Icons look light (bad) in the dark theme

[vogella]

Eclipse SDK
Version: 2022-06 (4.25)
Build id: I20220620-1050
OS: Windows 11, v.10.0, x86_64 / win32
Java vendor: Eclipse Adoptium
Java runtime version: 17.0.2+8
Java version: 17.0.2

The selected toolbar items looks light (bad)in the dark theme under Windows 11. Does the native support need enhancement for this?

[SyntevoAlex]

Doesn't look bad to me. Either way, our product doesn't use Toolbar, so I won't be able to work on it, sorry.

[vogella]

Doesn't look bad to me.

I highlighted the light buttons.

[SyntevoAlex]

Yes, I figured that you're talking about these buttons - yet, they don't look bad to me. Maybe not quite perfect :)

[jose-vasco]

They might not seem too bad in those very small items with only an icon (which will potentially be barely visible anyway), but it gets really bad on bigger icons / ToolItems with text. Plus, this bright background behavior also applies on hover, not just when in selected state.

[Andr2ea]

The different background colors when hovering over the buttons is inconsistent, based on the type of the button.
Dropdown:

Button:

Could be considered as a feature for distinguishing the different functionalities, but the difference in contrast between them is pretty strong.

[Andr2ea]

I also see that the highlights/font in tree views for dark mode is a work in progress
eclipse-platform/eclipse.platform.ui#3659