From d24385a8ce063b9f9158368fb62bf29ba3bd9f19 Mon Sep 17 00:00:00 2001 From: Jonathan Peppers Date: Mon, 30 Jun 2025 11:08:35 -0500 Subject: [PATCH] [copilot] allow `copilot-setup-steps.yml` to fail We found Copilot can go off track if: * Copilot commits a build error (of any kind). * You comment suggesting how to fix the build error. * Copilot setup steps will now fail, and Copilot can't fix it! So, once you are in this state, you can't really get Copilot back on track unless you manually fix it. Going forward, we should: * Allow the "build" step to fail * Upload the logs as an artifact Copilot should be able to do its work with a failing build. --- .github/workflows/copilot-setup-steps.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/copilot-setup-steps.yml b/.github/workflows/copilot-setup-steps.yml index 50bee8562d9..e0f56fd2e78 100644 --- a/.github/workflows/copilot-setup-steps.yml +++ b/.github/workflows/copilot-setup-steps.yml @@ -18,14 +18,16 @@ jobs: with: dotnet-version: '9.x' - - name: Run jenkins build + - name: Run android build + id: android-build + continue-on-error: true run: | make jenkins PREPARE_CI=1 PREPARE_AUTOPROVISION=1 CONFIGURATION=Debug timeout-minutes: 60 - name: Upload logs uses: actions/upload-artifact@v4 - if: failure() + if: steps.android-build.outcome == 'failure' with: name: copilot-artifacts path: |