Skip to content

fix: check how ions are imported currently #186

@sbillinge

Description

@sbillinge

Problem

The cif parser is now loading cif files with atom types specified as ions, e.g., Zr4+, without crashing. But we aren't sure whether it is just ignoring the 4+ or correcting the form factor for that case.

Proposed solution

Check the code. We would rather use a more comprehensive lookup table that has all the ions rather than turning them all to atoms by removing the "N+". Check if that is being done and do it if it isn't

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions