Skip to content

When the from path is an emptry string "" a null value is improperly assigned #40

Description

@brunerd

When the from path is "" it will be improperly assigned a null value

Example:
patch: [{"op":"copy","from":"","path":"/archive"}]
JSON: {"wow":"cool"}

The error message:
TypeError: null is not an object (evaluating 'from.get')
(same for move, although that should result in a warning)

Line 448:
var from = operation.from ? new JSONPointer(operation.from) : null;

This seems to be the culprit: operation.from is evaluating as "falsey" when it's an empty string so null is being returned by the ternary expression

One fix is:
var from = operation.from !== undefined ? new JSONPointer(operation.from) : null;

With that in place the operation completes as expected:

{
  "wow": "cool",
  "archive": {
    "wow": "cool"
  }
}

Or in the case of a move:
patch: [{"op":"move","from":"","path":"/archive"}]
JSON: {"wow":"cool"}

The proper result now displays:
Error: destination must not be a child of source

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions