Send PR#22
Open
rsxss wants to merge 24 commits into
Open
Conversation
Refactor sort import
Collaborator
|
นอนต่อเลยได้ไหม อย่าปล่อยให้ตัวฉันไป เธอก็รู้ว่าโค๊ดทั้งหมดอยู่ที่PR ตอนนี้ ก็จะแต่คำว่าบัคแทนคำบอกลา devmountain hackathon คงรู้ดี |
Author
|
55555555555 |
annibuliful
requested changes
Oct 12, 2022
| for record in records: | ||
| if convert_default and ( | ||
| record[10].text != "1" | ||
| or record[9].text not in ("Airhostess", "Pilot", "Steward") |
Collaborator
There was a problem hiding this comment.
Should keep ("Airhostess", "Pilot", "Steward") as new variable. it make more readable
| leap_days = 0 | ||
| target_date = datetime(int(date_str[6:]), int(date_str[3:5]), int(date_str[:2])) | ||
| for year in range(target_date.year, current_datetime.year + 2): | ||
| leap_days += not (year & 0b11) |
Collaborator
There was a problem hiding this comment.
0b11 is magic number so it would be better to create new variable to store it
Author
There was a problem hiding this comment.
Please explains the reason 0b11 is a magic number.
Collaborator
|
@rsxss ขอ email หน่อยครับ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ทีม นอนต่อเลยได้ไหม
สมาชิก 🤗
N.SX
Sathipp
Jiruschai
🔥 Repo: hackathon 🔥
👀 Visualization: link 👀